[web] introduce danger zone panel
AcceptedPublic
Actions

Authored by ginsu on Jan 28 2024, 11:02 PM.

Details

Reviewers

atul
inka
ashoat

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff introduces the danger zone panel and makes various UI changes to the DangerZone component so that it can be housed within the danger zone panel and matches the UI shown in the figma.

For context here is what the figma designs look like:

Screenshot 2024-01-29 at 2.04.34 AM.png (1×1 px, 77 KB)

Linear task: https://linear.app/comm/issue/ENG-5953/selected-settings-ui

Depends on D10850

Test Plan

Please see the screenshot below

Screenshot 2024-01-29 at 2.05.29 AM.png (2×3 px, 767 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 28 2024, 11:02 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 28 2024, 11:02 PM

ginsu edited the summary of this revision. (Show Details)Jan 28 2024, 11:05 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka, ashoat.

ginsu added a parent revision: D10850: [web] introduce keyserver selection list panel.

update

Made @ashoat a blocking reviewer since made a few changes to the copy

web/settings/danger-zone-panel.react.js
12	"Danger Zone" => "Danger zone"
web/settings/danger-zone.react.js
20		"Delete Account" => "Delete account"
27		"Delete Account" => "Delete account"
20 ↗	(On Diff #36223)	"Delete Account" => "Delete account"

ginsu edited the summary of this revision. (Show Details)Jan 28 2024, 11:11 PM

ginsu added a child revision: D10856: [web] introduce account settings panel.Jan 28 2024, 11:17 PM

Harbormaster completed remote builds in B26230: Diff 36223.Jan 28 2024, 11:28 PM

Harbormaster completed remote builds in B26231: Diff 36224.Jan 28 2024, 11:38 PM

ginsu requested review of this revision.Jan 28 2024, 11:38 PM

Copy changes look good. Just a question inline

web/settings/danger-zone.react.js
30–31	Should we make the same changes in `AccountDeleteModal`? Actually wondering if we really need to repeat this copy, both here and in `AccountDeleteModal`. What do you think?