[web] introduce account settings panel
AcceptedPublic
Actions

Authored by ginsu on Jan 28 2024, 11:12 PM.

Details

Reviewers

atul
inka
ashoat

Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff introduces the account settings panel and makes various ui changes to the AccountSettings component so that it can be housed within the account settings panel and matches the UI shown in the figma doc

For context here is what the designs look like on figma:

Screenshot 2024-01-29 at 2.20.29 AM.png (1×1 px, 105 KB)

Linear task: https://linear.app/comm/issue/ENG-5953/selected-settings-ui

Depends on D10855

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 28 2024, 11:12 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 28 2024, 11:12 PM

ginsu edited the summary of this revision. (Show Details)Jan 28 2024, 11:14 PM

ginsu edited the summary of this revision. (Show Details)Jan 28 2024, 11:17 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka, ashoat.

ginsu added a parent revision: D10855: [web] introduce danger zone panel.

Made @ashoat blocking reviewer since there are some changes to the copy in this diff

web/settings/account-settings-panel.react.js
12	"My Account" => "My account"
web/settings/account-settings.react.js
157–158	Decided to keep these settings here for now since they are gated to external users + there are currently no designs for these settings panels + felt like outside the scope of this diff. When we decide to make these settings available to external users I will then think more critically about the designs of these settings and make the necessary updates