[web][native] Rename decryptMedia to fetchAndDecryptMedia
ClosedPublic
Actions

Authored by bartek on Feb 1 2024, 1:25 AM.

Details

Reviewers

Commits

rCOMM887894201f17: [web][native] Rename decryptMedia to fetchAndDecryptMedia

Summary

I think this name is more accurate to what this function does. Especially in context of why we're going to pass CSAT into it (next diffs)

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 1 2024, 1:25 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 1 2024, 1:25 AM

Harbormaster failed remote builds in B26399: Diff 36501!Feb 1 2024, 1:37 AM

Commit missing line

bartek published this revision for review.Feb 1 2024, 1:54 AM

Harbormaster completed remote builds in B26401: Diff 36503.Feb 1 2024, 2:03 AM

bartek added a child revision: D10910: [native] Pass CSAT to Blob service when fetching multimedia.Feb 1 2024, 4:13 AM

Looks like straightforward rename

This revision is now accepted and ready to land.Feb 5 2024, 12:19 PM

Closed by commit rCOMM887894201f17: [web][native] Rename decryptMedia to fetchAndDecryptMedia (authored by bartek). · Explain WhyFeb 7 2024, 1:35 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM887894201f17: [web][native] Rename decryptMedia to fetchAndDecryptMedia.

Revision Contents
Changeset List

Path

Size

native/

media/

encrypted-image.react.js

4 lines

encryption-utils.js

4 lines

save-media.js

4 lines

video-playback-modal.react.js

4 lines

web/

media/

encrypted-multimedia.react.js

4 lines

encryption-utils.js

4 lines

loadable-video.react.js

4 lines

Diff 36771

View Options

native/media/encrypted-image.react.js

View Options

native/media/encryption-utils.js

View Options

native/media/save-media.js

View Options

native/media/video-playback-modal.react.js

View Options

web/media/encrypted-multimedia.react.js

View Options

web/media/encryption-utils.js

View Options

web/media/loadable-video.react.js

[web][native] Rename decryptMedia to fetchAndDecryptMediaClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36771

native/media/encrypted-image.react.js

native/media/encryption-utils.js

native/media/save-media.js

native/media/video-playback-modal.react.js

web/media/encrypted-multimedia.react.js

web/media/encryption-utils.js

web/media/loadable-video.react.js

[web][native] Rename decryptMedia to fetchAndDecryptMedia
ClosedPublic
Actions

Revision Contents
Changeset List