[lib] Add optional Authorization header to reports endpoint
ClosedPublic
Actions

Authored by bartek on Feb 2 2024, 1:10 AM.

Details

Reviewers

tomek
michal

Commits

rCOMMe9f3781d057f: [lib] Add optional Authorization header to reports endpoint

Summary

Part of ENG-6289.

Added a way to pass optional AuthMetadata to reports endpoint.
This header is optional because this endpoint should also work without any authentication.
Authentication gives us possibility to identify the user who is sending the report.

Depends on D10913

Test Plan

Tested together with the next diff.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 2 2024, 1:10 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 2 2024, 1:11 AM

bartek added a child revision: D10931: [lib][native] Pass CSAT to Reports endpoint.Feb 2 2024, 1:13 AM

Harbormaster completed remote builds in B26460: Diff 36578.Feb 2 2024, 1:39 AM

bartek published this revision for review.Feb 2 2024, 2:33 AM

tomek accepted this revision.Feb 6 2024, 1:40 AM

This revision is now accepted and ready to land.Feb 6 2024, 1:40 AM

Closed by commit rCOMMe9f3781d057f: [lib] Add optional Authorization header to reports endpoint (authored by bartek). · Explain WhyFeb 8 2024, 7:57 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe9f3781d057f: [lib] Add optional Authorization header to reports endpoint.

Revision Contents
Changeset List

Path

Size

lib/

actions/

report-actions.js

6 lines

utils/

reports-service.js

8 lines

Diff 36855

View Options

lib/actions/report-actions.js

	Show First 20 Lines • Show All 137 Lines • ▼ Show 20 Lines
	} from './messages/unsupported.js';			} from './messages/unsupported.js';
	import type {			import type {
	RawUpdateRelationshipMessageInfo,			RawUpdateRelationshipMessageInfo,
	UpdateRelationshipMessageData,			UpdateRelationshipMessageData,
	UpdateRelationshipMessageInfo,			UpdateRelationshipMessageInfo,
	} from './messages/update-relationship.js';			} from './messages/update-relationship.js';
	import { rawUpdateRelationshipMessageInfoValidator } from './messages/update-relationship.js';			import { rawUpdateRelationshipMessageInfoValidator } from './messages/update-relationship.js';
	import { type RelativeUserInfo, type UserInfos } from './user-types.js';			import { type RelativeUserInfo, type UserInfos } from './user-types.js';
	import type { CallSingleKeyserverEndpointResultInfoInterface } from '../keyserver-conn/call-single-keyserver-endpoint.js';
	import { values } from '../utils/objects.js';			import { values } from '../utils/objects.js';
	import { tID, tNumber, tShape, tUserID } from '../utils/validation-utils.js';			import { tID, tNumber, tShape, tUserID } from '../utils/validation-utils.js';

	const composableMessageTypes = new Set([			const composableMessageTypes = new Set([
	messageTypes.TEXT,			messageTypes.TEXT,
	messageTypes.IMAGES,			messageTypes.IMAGES,
	messageTypes.MULTIMEDIA,			messageTypes.MULTIMEDIA,
	]);			]);
	▲ Show 20 Lines • Show All 446 Lines • ▼ Show 20 Lines
	export const defaultMaxMessageAge = 14 * 24 * 60 * 60 * 1000; // 2 weeks			export const defaultMaxMessageAge = 14 * 24 * 60 * 60 * 1000; // 2 weeks

	export type SendMessageResponse = {			export type SendMessageResponse = {
	+newMessageInfo: RawMessageInfo,			+newMessageInfo: RawMessageInfo,
	};			};
	export type SendMessageResult = {			export type SendMessageResult = {
	+id: string,			+id: string,
	+time: number,			+time: number,
	+interface: CallSingleKeyserverEndpointResultInfoInterface,
	};			};

	export type SendMessagePayload = {			export type SendMessagePayload = {
	+localID: string,			+localID: string,
	+serverID: string,			+serverID: string,
	+threadID: string,			+threadID: string,
	+time: number,			+time: number,
	+interface: CallSingleKeyserverEndpointResultInfoInterface,
	};			};

	export type SendTextMessageRequest = {			export type SendTextMessageRequest = {
	+threadID: string,			+threadID: string,
	+localID?: string,			+localID?: string,
	+text: string,			+text: string,
	+sidebarCreation?: boolean,			+sidebarCreation?: boolean,
	};			};
	▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines