Follow up discussion from https://phab.comm.dev/D10908?id=36504#inline-66205
Details
Details
- Repeated test plan from D10908 (also repeated test plans for web and native from future diffs to make sure it works on all platforms)
- Added unit test
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Adding @ashoat because of dependency changes.
This dep was already in native, I copy-pasted it to lib, so no yarn.lock changes
Comment Actions
Makes sense. I suppose we could use native implementations in some places (eg. Node.js), but not sure it matters too much for performance.
Comment Actions
I did a quick benchmark: the base-64 lib vs Node Buffer vs web btoa and the differences are negligible for such small payloads (the Authorization payload is ~600-700 bytes long). All times were under 1ms.
Performance matters for encrypted multimedia, where payloads' sizes are hundreds of kB to dozens of MB.