[lib] Add function to create HTTP Authorization header
ClosedPublic
Actions

Authored by bartek on Feb 2 2024, 12:00 AM.

Details

Reviewers

ashoat
tomek
michal

Commits

rCOMM73ff928c9e0a: [lib] Add function to create HTTP Authorization header

Summary

Follow up discussion from https://phab.comm.dev/D10908?id=36504#inline-66205

Added base-64 dependency to lib (it already was in native)
Extracted createHTTPAuthorizationHeader function from D10908 - the header format is described in ENG-4657
Used base-64 in the function instead of passing platform-specific b64 implementations

Test Plan

Repeated test plan from D10908 (also repeated test plans for web and native from future diffs to make sure it works on all platforms)
Added unit test

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 2 2024, 12:00 AM

bartek held this revision as a draft.

bartek mentioned this in D10908: [keyserver] Authorize blob service requests.

bartek added a child revision: D10908: [keyserver] Authorize blob service requests.Feb 2 2024, 12:02 AM

bartek edited the summary of this revision. (Show Details)Feb 2 2024, 12:05 AM

Harbormaster completed remote builds in B26455: Diff 36573.Feb 2 2024, 12:19 AM

Adding @ashoat because of dependency changes.
This dep was already in native, I copy-pasted it to lib, so no yarn.lock changes

Makes sense. I suppose we could use native implementations in some places (eg. Node.js), but not sure it matters too much for performance.

This revision is now accepted and ready to land.Feb 2 2024, 8:18 AM

In D10929#315352, @ashoat wrote:

Makes sense. I suppose we could use native implementations in some places (eg. Node.js), but not sure it matters too much for performance.

I did a quick benchmark: the base-64 lib vs Node Buffer vs web btoa and the differences are negligible for such small payloads (the Authorization payload is ~600-700 bytes long). All times were under 1ms.

Performance matters for encrypted multimedia, where payloads' sizes are hundreds of kB to dozens of MB.

Closed by commit rCOMM73ff928c9e0a: [lib] Add function to create HTTP Authorization header (authored by bartek). · Explain WhyFeb 7 2024, 1:59 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM73ff928c9e0a: [lib] Add function to create HTTP Authorization header.