Page MenuHomePhabricator

[web] Only open tunnelbroker on the active tab
ClosedPublic

Authored by michal on Feb 20 2024, 4:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 4:15 PM
Unknown Object (File)
Fri, Nov 8, 1:41 AM
Unknown Object (File)
Fri, Nov 8, 1:25 AM
Unknown Object (File)
Fri, Nov 8, 12:41 AM
Unknown Object (File)
Fri, Nov 8, 12:01 AM
Unknown Object (File)
Oct 14 2024, 9:46 PM
Unknown Object (File)
Oct 14 2024, 9:46 PM
Unknown Object (File)
Oct 14 2024, 9:46 PM
Subscribers

Details

Summary

ENG-6668 : Only open tunnelbroker on a tab with a lock

Using the previously useWebLock hook, we can open the tunnelbroker connection only on one of the tabs in the foreground.

Depends on D11114

Test Plan

Switch between different tabs, make sure after a little bit of time (disconnetion of the previous tab and connection of the current tab) the new tabs connects to the tunnelbroker. Make sure that if multiple tabs are visible and in the foreground, only one tab connects to the tunnelbroker.

Because of ENG-6875 I introduced a quickfix to test this diff. I will wait with landing and after the issue is resolved I will re-test it.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 4 2024, 6:00 AM