[native] Don't overwrite main SQLCipher key when creating logs key
ClosedPublic
Actions

Authored by ashoat on Feb 21 2024, 12:36 PM.

Details

Reviewers

michal
kamil
atul
varun
tomek

Commits

rCOMM767ec2a17fac: [native] Don't overwrite main SQLCipher key when creating logs key

Summary

This resolves ENG-6826. The issue is described in this comment.

Test Plan

I tested upgrading from 314 -> 316 on my Android device. Prior to this diff, it would always result in the bug. After this diff, the bug no longer occurred.

In addition, I tested upgrading from 314 -> master in the same way.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 21 2024, 12:36 PM

ashoat published this revision for review.Feb 21 2024, 12:39 PM

Harbormaster completed remote builds in B27044: Diff 37412.Feb 21 2024, 12:52 PM

Looks good. Also looks like we don't need to run yarn build-db-wasm on these changes

This revision is now accepted and ready to land.Feb 21 2024, 1:04 PM

Closed by commit rCOMM767ec2a17fac: [native] Don't overwrite main SQLCipher key when creating logs key (authored by ashoat). · Explain WhyFeb 21 2024, 4:22 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM767ec2a17fac: [native] Don't overwrite main SQLCipher key when creating logs key.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.h

3 lines

SQLiteQueryExecutor.cpp

20 lines

Diff 37412

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h