Page MenuHomePhabricator

[native] Use connectivity instead of keyserver connection status in Calendar
ClosedPublic

Authored by tomek on Feb 29 2024, 2:50 AM.
Tags
None
Referenced Files
F3107692: D11195.diff
Thu, Oct 31, 7:08 AM
Unknown Object (File)
Thu, Oct 10, 11:33 AM
Unknown Object (File)
Thu, Oct 10, 11:19 AM
Unknown Object (File)
Sep 30 2024, 12:32 AM
Unknown Object (File)
Sep 28 2024, 3:53 PM
Unknown Object (File)
Sep 16 2024, 2:00 PM
Unknown Object (File)
Sep 16 2024, 2:00 PM
Unknown Object (File)
Sep 16 2024, 1:58 PM
Subscribers

Details

Summary

Each keyserver can have different connection status and modifying this logic to take this into account could be complicated. Instead, we can simply check if we're connected to network at all and try to load more entries. If, for some reason, some keyservers won't receive this update, CalendarQueryHandler should fix it later, based on currentCalendarQuery which is updated on updateCalendarQueryActionTypes.started.

https://linear.app/comm/issue/ENG-5772/update-calendar-component

Depends on D11187

Test Plan

Run the app, scroll the calendar - it should update, disconnect Wi-Fi, scroll again - shouldn't update, connect - should update. This doesn't work reliably on a simulator - NetInfo doesn't always fire correct events, but the logic of Calendar works correctly according to the emitted events.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable