Page MenuHomePhabricator
Differential D11196

[native][web] Check connectivity if a keyserver associated with an entry
ClosedPublic
Actions

Authored by tomek on Feb 29 2024, 4:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 8:20 AM
Unknown Object (File)
Fri, Mar 21, 2:30 PM
Unknown Object (File)
Feb 18 2025, 2:29 AM
Unknown Object (File)
Feb 16 2025, 12:45 AM
Unknown Object (File)
Feb 16 2025, 12:45 AM
Unknown Object (File)
Feb 16 2025, 12:45 AM
Unknown Object (File)
Feb 16 2025, 12:45 AM
Unknown Object (File)
Feb 5 2025, 7:32 PM
View All 64 Files
Subscribers
ashoat

Details

Reviewers
atul
inka
kamil
Commits
rCOMMe737ed0537e8: [native][web] Check connectivity if a keyserver associated with an entry
Summary

We're getting a keyserver id from a thread id and check the connectivity with that keyserver instead of the authoritative one.

https://linear.app/comm/issue/ENG-5773/update-entry-component

Depends on D11195

Test Plan

On both web and native: kill a keyserver, create an entry, run a keyserver - an entry should be created automatically.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
calendar/
15 lines
web/
calendar/
10 lines

Diff 37697

View Options

native/calendar/entry.react.js

Show All 10 Lines
type Props = { type Props = {
+placeholder: ?ImageSource, +placeholder: ?ImageSource,
+source: ?ImageSource, +source: ?ImageSource,
+onLoad?: () => void, +onLoad?: () => void,
+spinnerColor: string, +spinnerColor: string,
+style: ImageStyle, +style: ImageStyle,
+invisibleLoad: boolean, +invisibleLoad: boolean,
+errorOccured?: boolean, +errorOccurred?: boolean,
}; };
function LoadableImage(props: Props): React.Node { function LoadableImage(props: Props): React.Node {
const { source, placeholder, onLoad: onLoadProp, errorOccured } = props; const { source, placeholder, onLoad: onLoadProp, errorOccurred } = props;
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const [loaded, setLoaded] = React.useState(false); const [loaded, setLoaded] = React.useState(false);
const [error, setError] = React.useState(false); const [error, setError] = React.useState(false);
const onError = React.useCallback(() => { const onError = React.useCallback(() => {
setError(true); setError(true);
}, []); }, []);
Show All 17 Lines return (
onLoad={onLoad} onLoad={onLoad}
onError={onError} onError={onError}
style={invisibleStyle} style={invisibleStyle}
/> />
); );
} }
let statusIndicator; let statusIndicator;
if (error || errorOccured) { if (error || errorOccurred) {
statusIndicator = ( statusIndicator = (
<View style={styles.statusIndicatorContainer}> <View style={styles.statusIndicatorContainer}>
<Icon name="alert-circle" style={styles.errorIndicator} size={42} /> <Icon name="alert-circle" style={styles.errorIndicator} size={42} />
</View> </View>
); );
} else if (!loaded) { } else if (!loaded) {
statusIndicator = ( statusIndicator = (
<View style={styles.statusIndicatorContainer}> <View style={styles.statusIndicatorContainer}>
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines
View Options

web/calendar/entry.react.js

Show All 10 Lines
type Props = { type Props = {
+placeholder: ?ImageSource, +placeholder: ?ImageSource,
+source: ?ImageSource, +source: ?ImageSource,
+onLoad?: () => void, +onLoad?: () => void,
+spinnerColor: string, +spinnerColor: string,
+style: ImageStyle, +style: ImageStyle,
+invisibleLoad: boolean, +invisibleLoad: boolean,
+errorOccured?: boolean, +errorOccurred?: boolean,
}; };
function LoadableImage(props: Props): React.Node { function LoadableImage(props: Props): React.Node {
const { source, placeholder, onLoad: onLoadProp, errorOccured } = props; const { source, placeholder, onLoad: onLoadProp, errorOccurred } = props;
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const [loaded, setLoaded] = React.useState(false); const [loaded, setLoaded] = React.useState(false);
const [error, setError] = React.useState(false); const [error, setError] = React.useState(false);
const onError = React.useCallback(() => { const onError = React.useCallback(() => {
setError(true); setError(true);
}, []); }, []);
Show All 17 Lines return (
onLoad={onLoad} onLoad={onLoad}
onError={onError} onError={onError}
style={invisibleStyle} style={invisibleStyle}
/> />
); );
} }
let statusIndicator; let statusIndicator;
if (error || errorOccured) { if (error || errorOccurred) {
statusIndicator = ( statusIndicator = (
<View style={styles.statusIndicatorContainer}> <View style={styles.statusIndicatorContainer}>
<Icon name="alert-circle" style={styles.errorIndicator} size={42} /> <Icon name="alert-circle" style={styles.errorIndicator} size={42} />
</View> </View>
); );
} else if (!loaded) { } else if (!loaded) {
statusIndicator = ( statusIndicator = (
<View style={styles.statusIndicatorContainer}> <View style={styles.statusIndicatorContainer}>
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines