Page MenuHomePhabricator
Differential D11196

[native][web] Check connectivity if a keyserver associated with an entry
ClosedPublic
Actions

Authored by tomek on Feb 29 2024, 4:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 6:10 PM
Unknown Object (File)
Thu, Apr 17, 9:16 PM
Unknown Object (File)
Thu, Apr 17, 1:39 AM
Unknown Object (File)
Wed, Apr 16, 8:50 PM
Unknown Object (File)
Tue, Apr 15, 9:58 PM
Unknown Object (File)
Fri, Mar 28, 8:20 AM
Unknown Object (File)
Mar 21 2025, 2:30 PM
Unknown Object (File)
Feb 18 2025, 2:29 AM
View All 69 Files
Subscribers
ashoat

Details

Reviewers
atul
inka
kamil
Commits
rCOMMe737ed0537e8: [native][web] Check connectivity if a keyserver associated with an entry
Summary

We're getting a keyserver id from a thread id and check the connectivity with that keyserver instead of the authoritative one.

https://linear.app/comm/issue/ENG-5773/update-entry-component

Depends on D11195

Test Plan

On both web and native: kill a keyserver, create an entry, run a keyserver - an entry should be created automatically.

Diff Detail

Repository
rCOMM Comm
Branch
sockets
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
calendar/
15 lines
web/
calendar/
10 lines

Diff 37685

View Options

native/calendar/entry.react.js

Show First 20 Lines • Show All 155 Lines • ▼ Show 20 Lines
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
// Redux state // Redux state
+dimensions: DerivedDimensionsInfo, +dimensions: DerivedDimensionsInfo,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
+isActive: boolean, +isActive: boolean,
};
type State = {
+closeButtonEnabled: boolean, +closeButtonEnabled: boolean,
+actionLinksEnabled: boolean, +actionLinksEnabled: boolean,
}; +updateCloseButtonEnabled: ([number]) => void,
class FullScreenViewModal extends React.PureComponent<Props, State> { +updateActionLinksEnabled: ([number]) => void,
state: State = {
closeButtonEnabled: true,
actionLinksEnabled: true,
}; };
class FullScreenViewModal extends React.PureComponent<Props> {
closeButton: ?React.ElementRef<TouchableOpacityInstance>; closeButton: ?React.ElementRef<TouchableOpacityInstance>;
mediaIconsContainer: ?React.ElementRef<typeof View>; mediaIconsContainer: ?React.ElementRef<typeof View>;
closeButtonX: Value = new Value(-1); closeButtonX: Value = new Value(-1);
closeButtonY: Value = new Value(-1); closeButtonY: Value = new Value(-1);
closeButtonWidth: Value = new Value(0); closeButtonWidth: Value = new Value(0);
closeButtonHeight: Value = new Value(0); closeButtonHeight: Value = new Value(0);
closeButtonLastState: Value = new Value(1); closeButtonLastState: Value = new Value(1);
mediaIconsX: Value = new Value(-1); mediaIconsX: Value = new Value(-1);
▲ Show 20 Lines • Show All 472 Lines • ▼ Show 20 Lines return block([
], ],
), ),
), ),
set(this.actionLinksLastState, actionLinksState), set(this.actionLinksLastState, actionLinksState),
set(this.closeButtonLastState, closeButtonState), set(this.closeButtonLastState, closeButtonState),
set(wasZoomed, isZoomed), set(wasZoomed, isZoomed),
set(lastTapX, singleTapX), set(lastTapX, singleTapX),
set(lastTapY, singleTapY), set(lastTapY, singleTapY),
call([eq(curCloseButtonOpacity, 1)], this.setCloseButtonEnabled), call([eq(curCloseButtonOpacity, 1)], this.props.updateCloseButtonEnabled),
call([eq(curActionLinksOpacity, 1)], this.setActionLinksEnabled), call([eq(curActionLinksOpacity, 1)], this.props.updateActionLinksEnabled),
]); ]);
} }
doubleTapUpdate( doubleTapUpdate(
// Inputs // Inputs
doubleTapState: Node, doubleTapState: Node,
doubleTapX: Node, doubleTapX: Node,
doubleTapY: Node, doubleTapY: Node,
▲ Show 20 Lines • Show All 316 Lines • ▼ Show 20 Lines const mediaIconsButtonStyle = {
opacity: this.actionLinksOpacity, opacity: this.actionLinksOpacity,
}; };
let saveButton; let saveButton;
if (saveContentCallback) { if (saveContentCallback) {
saveButton = ( saveButton = (
<TouchableOpacity <TouchableOpacity
onPress={saveContentCallback} onPress={saveContentCallback}
disabled={!this.state.actionLinksEnabled} disabled={!this.props.actionLinksEnabled}
style={styles.mediaIconButtons} style={styles.mediaIconButtons}
> >
<SWMansionIcon name="save" style={styles.mediaIcon} /> <SWMansionIcon name="save" style={styles.mediaIcon} />
<Text style={styles.mediaIconText}>Save</Text> <Text style={styles.mediaIconText}>Save</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
let copyButton; let copyButton;
if (Platform.OS === 'ios' && copyContentCallback) { if (Platform.OS === 'ios' && copyContentCallback) {
copyButton = ( copyButton = (
<TouchableOpacity <TouchableOpacity
onPress={copyContentCallback} onPress={copyContentCallback}
disabled={!this.state.actionLinksEnabled} disabled={!this.props.actionLinksEnabled}
style={styles.mediaIconButtons} style={styles.mediaIconButtons}
> >
<SWMansionIcon name="copy" style={styles.mediaIcon} /> <SWMansionIcon name="copy" style={styles.mediaIcon} />
<Text style={styles.mediaIconText}>Copy</Text> <Text style={styles.mediaIconText}>Copy</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
Show All 26 Lines const view = (
</View> </View>
<SafeAreaView style={styles.buttonsOverlay}> <SafeAreaView style={styles.buttonsOverlay}>
<View style={styles.fill}> <View style={styles.fill}>
<Animated.View <Animated.View
style={[styles.closeButtonContainer, closeButtonStyle]} style={[styles.closeButtonContainer, closeButtonStyle]}
> >
<TouchableOpacity <TouchableOpacity
onPress={this.close} onPress={this.close}
disabled={!this.state.closeButtonEnabled} disabled={!this.props.closeButtonEnabled}
onLayout={this.onCloseButtonLayout} onLayout={this.onCloseButtonLayout}
ref={this.closeButtonRef} ref={this.closeButtonRef}
> >
<Text style={styles.closeButton}>×</Text> <Text style={styles.closeButton}>×</Text>
</TouchableOpacity> </TouchableOpacity>
</Animated.View> </Animated.View>
{mediaActionButtons} {mediaActionButtons}
</View> </View>
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines return (
</PinchGestureHandler> </PinchGestureHandler>
); );
} }
close = () => { close = () => {
this.props.navigation.goBackOnce(); this.props.navigation.goBackOnce();
}; };
setCloseButtonEnabled = ([enabledNum]: [number]) => {
const enabled = !!enabledNum;
if (this.state.closeButtonEnabled !== enabled) {
this.setState({ closeButtonEnabled: enabled });
}
};
setActionLinksEnabled = ([enabledNum]: [number]) => {
const enabled = !!enabledNum;
if (this.state.actionLinksEnabled !== enabled) {
this.setState({ actionLinksEnabled: enabled });
}
};
closeButtonRef = ( closeButtonRef = (
closeButton: ?React.ElementRef<typeof TouchableOpacity>, closeButton: ?React.ElementRef<typeof TouchableOpacity>,
) => { ) => {
this.closeButton = (closeButton: any); this.closeButton = (closeButton: any);
}; };
mediaIconsRef = (mediaIconsContainer: ?React.ElementRef<typeof View>) => { mediaIconsRef = (mediaIconsContainer: ?React.ElementRef<typeof View>) => {
this.mediaIconsContainer = mediaIconsContainer; this.mediaIconsContainer = mediaIconsContainer;
▲ Show 20 Lines • Show All 116 Lines • ▼ Show 20 Lines ) {
}, [isActive]); }, [isActive]);
React.useEffect(() => { React.useEffect(() => {
return () => { return () => {
Orientation.lockToPortrait(); Orientation.lockToPortrait();
}; };
}, []); }, []);
const [closeButtonEnabled, setCloseButtonEnabled] = React.useState(true);
const [actionLinksEnabled, setActionLinksEnabled] = React.useState(true);
const updateCloseButtonEnabled = React.useCallback(
([enabledNum]: [number]) => {
tomekUnsubmitted
Not Done
Inline Actions

We should prefer Array type

tomek: We should prefer `Array` type
angelikaAuthorUnsubmitted
Done
Inline Actions

This was just copied from the original code and the [number] argument will be replaced with number argument in https://phab.comm.dev/D14304 anyway

angelika: This was just copied from the original code and the `[number]` argument will be replaced with…
const enabled = !!enabledNum;
if (closeButtonEnabled !== enabled) {
setCloseButtonEnabled(enabled);
}
},
[closeButtonEnabled],
);
const updateActionLinksEnabled = React.useCallback(
([enabledNum]: [number]) => {
const enabled = !!enabledNum;
if (actionLinksEnabled !== enabled) {
setActionLinksEnabled(enabled);
}
},
[actionLinksEnabled],
);
return ( return (
<FullScreenViewModal <FullScreenViewModal
{...props} {...props}
dimensions={dimensions} dimensions={dimensions}
overlayContext={overlayContext} overlayContext={overlayContext}
isActive={isActive} isActive={isActive}
closeButtonEnabled={closeButtonEnabled}
actionLinksEnabled={actionLinksEnabled}
updateCloseButtonEnabled={updateCloseButtonEnabled}
updateActionLinksEnabled={updateActionLinksEnabled}
/> />
); );
}); });
export default ConnectedFullScreenViewModal; export default ConnectedFullScreenViewModal;
View Options

web/calendar/entry.react.js

Show First 20 Lines • Show All 155 Lines • ▼ Show 20 Lines
}; };
type Props = { type Props = {
...BaseProps, ...BaseProps,
// Redux state // Redux state
+dimensions: DerivedDimensionsInfo, +dimensions: DerivedDimensionsInfo,
// withOverlayContext // withOverlayContext
+overlayContext: ?OverlayContextType, +overlayContext: ?OverlayContextType,
+isActive: boolean, +isActive: boolean,
};
type State = {
+closeButtonEnabled: boolean, +closeButtonEnabled: boolean,
+actionLinksEnabled: boolean, +actionLinksEnabled: boolean,
}; +updateCloseButtonEnabled: ([number]) => void,
class FullScreenViewModal extends React.PureComponent<Props, State> { +updateActionLinksEnabled: ([number]) => void,
state: State = {
closeButtonEnabled: true,
actionLinksEnabled: true,
}; };
class FullScreenViewModal extends React.PureComponent<Props> {
closeButton: ?React.ElementRef<TouchableOpacityInstance>; closeButton: ?React.ElementRef<TouchableOpacityInstance>;
mediaIconsContainer: ?React.ElementRef<typeof View>; mediaIconsContainer: ?React.ElementRef<typeof View>;
closeButtonX: Value = new Value(-1); closeButtonX: Value = new Value(-1);
closeButtonY: Value = new Value(-1); closeButtonY: Value = new Value(-1);
closeButtonWidth: Value = new Value(0); closeButtonWidth: Value = new Value(0);
closeButtonHeight: Value = new Value(0); closeButtonHeight: Value = new Value(0);
closeButtonLastState: Value = new Value(1); closeButtonLastState: Value = new Value(1);
mediaIconsX: Value = new Value(-1); mediaIconsX: Value = new Value(-1);
▲ Show 20 Lines • Show All 472 Lines • ▼ Show 20 Lines return block([
], ],
), ),
), ),
set(this.actionLinksLastState, actionLinksState), set(this.actionLinksLastState, actionLinksState),
set(this.closeButtonLastState, closeButtonState), set(this.closeButtonLastState, closeButtonState),
set(wasZoomed, isZoomed), set(wasZoomed, isZoomed),
set(lastTapX, singleTapX), set(lastTapX, singleTapX),
set(lastTapY, singleTapY), set(lastTapY, singleTapY),
call([eq(curCloseButtonOpacity, 1)], this.setCloseButtonEnabled), call([eq(curCloseButtonOpacity, 1)], this.props.updateCloseButtonEnabled),
call([eq(curActionLinksOpacity, 1)], this.setActionLinksEnabled), call([eq(curActionLinksOpacity, 1)], this.props.updateActionLinksEnabled),
]); ]);
} }
doubleTapUpdate( doubleTapUpdate(
// Inputs // Inputs
doubleTapState: Node, doubleTapState: Node,
doubleTapX: Node, doubleTapX: Node,
doubleTapY: Node, doubleTapY: Node,
▲ Show 20 Lines • Show All 316 Lines • ▼ Show 20 Lines const mediaIconsButtonStyle = {
opacity: this.actionLinksOpacity, opacity: this.actionLinksOpacity,
}; };
let saveButton; let saveButton;
if (saveContentCallback) { if (saveContentCallback) {
saveButton = ( saveButton = (
<TouchableOpacity <TouchableOpacity
onPress={saveContentCallback} onPress={saveContentCallback}
disabled={!this.state.actionLinksEnabled} disabled={!this.props.actionLinksEnabled}
style={styles.mediaIconButtons} style={styles.mediaIconButtons}
> >
<SWMansionIcon name="save" style={styles.mediaIcon} /> <SWMansionIcon name="save" style={styles.mediaIcon} />
<Text style={styles.mediaIconText}>Save</Text> <Text style={styles.mediaIconText}>Save</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
let copyButton; let copyButton;
if (Platform.OS === 'ios' && copyContentCallback) { if (Platform.OS === 'ios' && copyContentCallback) {
copyButton = ( copyButton = (
<TouchableOpacity <TouchableOpacity
onPress={copyContentCallback} onPress={copyContentCallback}
disabled={!this.state.actionLinksEnabled} disabled={!this.props.actionLinksEnabled}
style={styles.mediaIconButtons} style={styles.mediaIconButtons}
> >
<SWMansionIcon name="copy" style={styles.mediaIcon} /> <SWMansionIcon name="copy" style={styles.mediaIcon} />
<Text style={styles.mediaIconText}>Copy</Text> <Text style={styles.mediaIconText}>Copy</Text>
</TouchableOpacity> </TouchableOpacity>
); );
} }
Show All 26 Lines const view = (
</View> </View>
<SafeAreaView style={styles.buttonsOverlay}> <SafeAreaView style={styles.buttonsOverlay}>
<View style={styles.fill}> <View style={styles.fill}>
<Animated.View <Animated.View
style={[styles.closeButtonContainer, closeButtonStyle]} style={[styles.closeButtonContainer, closeButtonStyle]}
> >
<TouchableOpacity <TouchableOpacity
onPress={this.close} onPress={this.close}
disabled={!this.state.closeButtonEnabled} disabled={!this.props.closeButtonEnabled}
onLayout={this.onCloseButtonLayout} onLayout={this.onCloseButtonLayout}
ref={this.closeButtonRef} ref={this.closeButtonRef}
> >
<Text style={styles.closeButton}>×</Text> <Text style={styles.closeButton}>×</Text>
</TouchableOpacity> </TouchableOpacity>
</Animated.View> </Animated.View>
{mediaActionButtons} {mediaActionButtons}
</View> </View>
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines return (
</PinchGestureHandler> </PinchGestureHandler>
); );
} }
close = () => { close = () => {
this.props.navigation.goBackOnce(); this.props.navigation.goBackOnce();
}; };
setCloseButtonEnabled = ([enabledNum]: [number]) => {
const enabled = !!enabledNum;
if (this.state.closeButtonEnabled !== enabled) {
this.setState({ closeButtonEnabled: enabled });
}
};
setActionLinksEnabled = ([enabledNum]: [number]) => {
const enabled = !!enabledNum;
if (this.state.actionLinksEnabled !== enabled) {
this.setState({ actionLinksEnabled: enabled });
}
};
closeButtonRef = ( closeButtonRef = (
closeButton: ?React.ElementRef<typeof TouchableOpacity>, closeButton: ?React.ElementRef<typeof TouchableOpacity>,
) => { ) => {
this.closeButton = (closeButton: any); this.closeButton = (closeButton: any);
}; };
mediaIconsRef = (mediaIconsContainer: ?React.ElementRef<typeof View>) => { mediaIconsRef = (mediaIconsContainer: ?React.ElementRef<typeof View>) => {
this.mediaIconsContainer = mediaIconsContainer; this.mediaIconsContainer = mediaIconsContainer;
▲ Show 20 Lines • Show All 116 Lines • ▼ Show 20 Lines ) {
}, [isActive]); }, [isActive]);
React.useEffect(() => { React.useEffect(() => {
return () => { return () => {
Orientation.lockToPortrait(); Orientation.lockToPortrait();
}; };
}, []); }, []);
const [closeButtonEnabled, setCloseButtonEnabled] = React.useState(true);
const [actionLinksEnabled, setActionLinksEnabled] = React.useState(true);
const updateCloseButtonEnabled = React.useCallback(
([enabledNum]: [number]) => {
tomekUnsubmitted
Not Done
Inline Actions

We should prefer Array type

tomek: We should prefer `Array` type
angelikaAuthorUnsubmitted
Done
Inline Actions

This was just copied from the original code and the [number] argument will be replaced with number argument in https://phab.comm.dev/D14304 anyway

angelika: This was just copied from the original code and the `[number]` argument will be replaced with…
const enabled = !!enabledNum;
if (closeButtonEnabled !== enabled) {
setCloseButtonEnabled(enabled);
}
},
[closeButtonEnabled],
);
const updateActionLinksEnabled = React.useCallback(
([enabledNum]: [number]) => {
const enabled = !!enabledNum;
if (actionLinksEnabled !== enabled) {
setActionLinksEnabled(enabled);
}
},
[actionLinksEnabled],
);
return ( return (
<FullScreenViewModal <FullScreenViewModal
{...props} {...props}
dimensions={dimensions} dimensions={dimensions}
overlayContext={overlayContext} overlayContext={overlayContext}
isActive={isActive} isActive={isActive}
closeButtonEnabled={closeButtonEnabled}
actionLinksEnabled={actionLinksEnabled}
updateCloseButtonEnabled={updateCloseButtonEnabled}
updateActionLinksEnabled={updateActionLinksEnabled}
/> />
); );
}); });
export default ConnectedFullScreenViewModal; export default ConnectedFullScreenViewModal;