Page MenuHomePhabricator

[lib] Deprecate recoveryActionSources.sqliteOpFailure
ClosedPublic

Authored by ashoat on Mar 3 2024, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 7:32 PM
Unknown Object (File)
Fri, Nov 8, 2:59 AM
Unknown Object (File)
Fri, Nov 8, 2:21 AM
Unknown Object (File)
Tue, Oct 29, 12:48 PM
Unknown Object (File)
Oct 4 2024, 3:44 AM
Unknown Object (File)
Oct 4 2024, 3:44 AM
Unknown Object (File)
Oct 4 2024, 3:44 AM
Unknown Object (File)
Oct 4 2024, 3:43 AM
Subscribers
None

Details

Summary

Noticed in the last diff that this was unused. It was first introduced in D2154, and then removed by me in D5672. I neglected to deprecate the constant in that diff, unfortunately.

Following the practice elsewhere in the codebase (eg. thread-types-enum.js), I'm leaving the constant in but commenting it out. This lets us avoid causing any confusion by accidentally reintroducing the constant again in the future.

I could alternatively just delete it. Technically LogInActionSources are passed to the keyserver, but as far as I know nothing is done with them, so there isn't too much danger in deleting them. Open to this if reviewers prefer.

Depends on D11210

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Mar 3 2024, 9:00 PM
tomek accepted this revision.EditedMar 4 2024, 1:29 AM

I think that the practice of keeping commented-out types has a big advantage of reducing confusion when searching for older revisions while it doesn't have significant disadvantages.

This revision is now accepted and ready to land.Mar 4 2024, 1:29 AM