Page MenuHomePhabricator

[lib][native] Try session recovery on web too for policy acknowledgment crash loop
ClosedPublic

Authored by ashoat on Mar 3 2024, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 2:59 AM
Unknown Object (File)
Mon, May 13, 12:15 AM
Unknown Object (File)
Apr 4 2024, 7:02 PM
Unknown Object (File)
Apr 4 2024, 7:02 PM
Unknown Object (File)
Apr 4 2024, 6:43 PM
Unknown Object (File)
Mar 16 2024, 3:53 AM
Unknown Object (File)
Mar 15 2024, 11:07 AM
Unknown Object (File)
Mar 13 2024, 2:05 AM
Subscribers
None

Details

Summary

We have code that attempts a session recovery on native when we encounter a policy acknowledgment crash loop. However on web, we don't do anything.

I'm guessing this is the case for two reasons:

  1. Prior to recent changes, a refresh on web would easily resolve the issue.
  2. Keyserver session recovery used to only work on native since it required a password.

Since a refresh likely won't resolve the issue anymore, and since keyserver session recovery will soon be possible on web, I decided to make the code for attempting a session recovery work for web too.

Note that if a session recovery is not possible (or if the session recovery fails), this will result in the user's session being invalidated, and the user being logged out. I think this is probably for the best.

Note that the code for the Alert still needs to be native-specific. I don't have the cycles right now to implement an Alert for the web, but we should eventually do that too: ENG-6733

Depends on D11216

Test Plan

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable