Page MenuHomePhabricator
Differential D11212

[lib] Replace sessionRecoveryInProgress with actionSessionRecovery
ClosedPublic
Actions

Authored by ashoat on Mar 3 2024, 8:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 12:15 AM
Unknown Object (File)
Apr 5 2024, 12:12 AM
Unknown Object (File)
Apr 4 2024, 7:02 PM
Unknown Object (File)
Apr 4 2024, 6:43 PM
Unknown Object (File)
Mar 24 2024, 5:41 PM
Unknown Object (File)
Mar 16 2024, 2:59 AM
Unknown Object (File)
Mar 15 2024, 5:09 PM
Unknown Object (File)
Mar 15 2024, 1:03 PM
View All 20 Files
Subscribers
None

Details

Reviewers
inka
tomek
Commits
rCOMM7c9488ad1695: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery
Summary

This Redux field (part of ConnectionInfo inside KeyserverInfo) will now store a RecoveryActionSource instead of just a boolean. This will allow us to pass the RecoveryActionSource from the place where the session recovery is initiated to the place where the session recovery is executed (KeyserverConnectionHandler).

Depends on D11211

Test Plan

I used this test plan for the whole stack: https://gist.github.com/Ashoat/75ab690d5c53cdd68a51b02e03e27c58

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 3 2024, 8:44 PM
ashoat added a child revision: D11213: [native] Use unified keyserver session recovery in LoggedOutModal.
Harbormaster completed remote builds in B27268: Diff 37745.Mar 3 2024, 9:04 PM
ashoat requested review of this revision.Mar 3 2024, 9:04 PM
tomek accepted this revision.Mar 4 2024, 1:47 AM

Just to make sure: sessionRecoveryInProgress isn't persisted, right?

lib/keyserver-conn/call-keyserver-endpoint-provider.react.js
328 ↗(On Diff #37745)

Nit

lib/types/redux-types.js
1360–1363 ↗(On Diff #37745)

Should we delete this?

This revision is now accepted and ready to land.Mar 4 2024, 1:47 AM
ashoat added a comment.Mar 4 2024, 5:08 PM
In D11212#324223, @tomek wrote:

Just to make sure: sessionRecoveryInProgress isn't persisted, right?

That's right – all of ConnectionInfo is not persisted

lib/types/redux-types.js
1360–1363 ↗(On Diff #37745)

Oops yeah, good catch

ashoat updated this revision to Diff 37800.Mar 4 2024, 5:09 PM

@tomek's feedback

Harbormaster completed remote builds in B27316: Diff 37800.Mar 4 2024, 5:35 PM
Closed by commit rCOMM7c9488ad1695: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery (authored by ashoat). · Explain WhyMar 5 2024, 8:52 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM7c9488ad1695: [lib] Replace sessionRecoveryInProgress with actionSessionRecovery.

Revision Contents
Changeset List

PathSize
lib/
components/
142 lines
keyserver-conn/
34 lines
9 lines
3 lines
reducers/
18 lines
selectors/
5 lines
types/
9 lines
18 lines
utils/
7 lines
4 lines

Diff 37837

View Options

lib/components/keyserver-connection-handler.js

Loading...
View Options

lib/keyserver-conn/call-keyserver-endpoint-provider.react.js

Loading...
View Options

lib/keyserver-conn/keyserver-call-infos.js

Loading...
View Options

lib/keyserver-conn/keyserver-conn-types.js

Loading...
View Options

lib/reducers/keyserver-reducer.js

Loading...
View Options

lib/selectors/server-calls.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/socket-types.js

Loading...
View Options

lib/utils/action-utils.js

Loading...
View Options

lib/utils/keyserver-call.js

Loading...