This differential modifies CommCoreModule to work with notifications account that is persisted in SQLite. At the point of this diff notifications crypto
account exists in two places: in SQLite and in notifs storage. This isn't a mistake since only the one in SQLite will be used for cryptographic purposes since notifs
specific code only works with session. Next diff will remove notifs account from notifs storage.
Details
Details
- Uninstall comm app from iOS/Android device.
- Apply this patch and build the app: https://gist.github.com/marcinwasowicz/47964be1bd6aeaabc5504b3fa440f340
- Tap each button that the patch introduces. Ensure that keys are logged to console.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 351 ↗ | (On Diff #37792) | |
| 395 ↗ | (On Diff #37792) | |
| 399 ↗ | (On Diff #37792) | |
| 662 ↗ | (On Diff #37792) | |
| 694 ↗ | (On Diff #37792) | we return in line above sp we can make only if condition to make it more readable |
| 695–696 ↗ | (On Diff #37792) | are you sure this is the right condition? |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.h | ||
| 30 ↗ | (On Diff #37792) | I think we should now rename it to contentCryptoModule |
| native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp | ||
|---|---|---|
| 454–462 ↗ | (On Diff #37792) | Isn't this done in the constructor of CryptoModule? |