[lib] fix creating Tunnelbroker socket
ClosedPublic
Actions

Authored by kamil on Mar 4 2024, 7:25 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 8:21 AM

	Unknown Object (File)
	Sun, Jan 5, 8:18 AM

	Unknown Object (File)
	Sun, Jan 5, 5:53 AM

	Unknown Object (File)
	Sat, Dec 28, 1:11 PM

	Unknown Object (File)
	Sat, Dec 28, 1:11 PM

	Unknown Object (File)
	Sat, Dec 28, 1:11 PM

	Unknown Object (File)
	Sat, Dec 28, 1:10 PM

	Unknown Object (File)
	Sat, Dec 28, 1:10 PM

View All 60 Files

Subscribers

ashoat

tomek

Details

Reviewers

bartek
michal

Commits

rCOMMbe9961691484: [lib] fix creating Tunnelbroker socket

Summary

ENG-6875.

Previous code was creating multiple sockets on each re-render which was causing issues.

Test Plan

Add credentials and test if connection with Tunnelbroker works.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mar 4 2024, 7:25 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 4 2024, 7:25 AM

Harbormaster completed remote builds in B27301: Diff 37783.Mar 4 2024, 7:47 AM

kamil published this revision for review.Mar 4 2024, 9:22 AM

bartek accepted this revision.Mar 4 2024, 9:54 PM

This revision is now accepted and ready to land.Mar 4 2024, 9:54 PM

rebase

Harbormaster completed remote builds in B27318: Diff 37803.Mar 5 2024, 1:53 AM

Closed by commit rCOMMbe9961691484: [lib] fix creating Tunnelbroker socket (authored by kamil). · Explain WhyMar 5 2024, 1:55 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMbe9961691484: [lib] fix creating Tunnelbroker socket.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

tunnelbroker-context.js

9 lines

Diff 37804

View Options

lib/tunnelbroker/tunnelbroker-context.js

[lib] fix creating Tunnelbroker socketClosedPublicActions