Page MenuHomePhabricator
Differential D11251

[identity] let clap handle parsing env var to vec
ClosedPublic
Actions

Authored by varun on Mar 5 2024, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 12:13 PM
Unknown Object (File)
Tue, Nov 12, 8:59 AM
Unknown Object (File)
Tue, Nov 12, 7:53 AM
Unknown Object (File)
Tue, Nov 12, 3:24 AM
Unknown Object (File)
Oct 10 2024, 12:16 PM
Unknown Object (File)
Oct 10 2024, 12:16 PM
Unknown Object (File)
Oct 10 2024, 12:15 PM
Unknown Object (File)
Oct 10 2024, 11:33 AM
View All 47 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
bartek
Commits
rCOMM1319a7577335: [identity] let clap handle parsing env var to vec
Summary

rather than split the string ourselves, we can let clap handle this

Depends on D11250

Test Plan

tested on staging -- origins were parsed correctly and validated, only the listed origins were allowed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 5 2024, 3:23 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 5 2024, 3:23 PM
Harbormaster completed remote builds in B27347: Diff 37868.Mar 5 2024, 3:52 PM
varun requested review of this revision.Mar 5 2024, 3:52 PM
bartek accepted this revision.Mar 6 2024, 3:55 AM
bartek added inline comments.
services/identity/src/config.rs
110–111 ↗(On Diff #37868)

We shouldn't have to clone when we only want a slice.

Also, not sure if my suggestion works without doing .map(|s| vec_to_allow_origin(s.as_slice()))

192 ↗(On Diff #37868)

Technically we should use slices

This revision is now accepted and ready to land.Mar 6 2024, 3:55 AM
Closed by commit rCOMM1319a7577335: [identity] let clap handle parsing env var to vec (authored by varun). · Explain WhyMar 6 2024, 10:45 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM1319a7577335: [identity] let clap handle parsing env var to vec.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
11 lines

Diff 37899

View Options

services/identity/src/config.rs

Loading...