[lib] Don't sync users with non-authoritative keyservers
ClosedPublic
Actions

Authored by tomek on Mar 7 2024, 4:52 AM.

Details

Reviewers

inka
kamil
michal
varun

Commits

rCOMMc40428a2d017: [lib] Don't sync users with non-authoritative keyservers

Summary

We can take a similar approach to what we do with threads that are being hashed - inform the server that there are no inconsistencies. This is a kind of hack, but it will be later improved when we start syncing the store between clients - then the keyserver will no longer attempt the sync.

https://linear.app/comm/issue/ENG-7132/stop-performing-state-sync-of-users-and-current-user-with-non

Test Plan

Check if the state sync still works for one keyserver - modify keyserver DB and check if the state is fixed.
Connect to the second keyserver and check if the state difference doesn't cause an update on client side - modified username on the authoritative keyserver and checked if the name remains changed after state sync with the second keyserver.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 7 2024, 4:52 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 7 2024, 4:52 AM

tomek edited the test plan for this revision. (Show Details)Mar 7 2024, 4:53 AM

Harbormaster completed remote builds in B27381: Diff 37922.Mar 7 2024, 5:07 AM

tomek requested review of this revision.Mar 7 2024, 5:07 AM

This is quite hacky, but I guess it's fine since it's temporary

This revision is now accepted and ready to land.Mar 8 2024, 1:39 AM

Closed by commit rCOMMc40428a2d017: [lib] Don't sync users with non-authoritative keyservers (authored by tomek). · Explain WhyMar 8 2024, 4:55 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMc40428a2d017: [lib] Don't sync users with non-authoritative keyservers.

Is this is a temporary hack, shouldn't we have a Linear task to revert it?

In D11271#325677, @ashoat wrote:

Is this is a temporary hack, shouldn't we have a Linear task to revert it?

This is a temporary hack, and this code will be completely removed / reworked as a part of https://linear.app/comm/issue/ENG-4730/syncing-keyserverstore-and-userstore-without-keyserver - so we don't need a dedicated task to handle it.