If usingCommServicesAccessToken, we should call the identity service RPC instead of the keyserver exactSearchUser API
if the username is reserved or registered on the identity service, we should set the username_taken error
Details
Details
enabled usingCSAT and tried to register an already registered and a reserved username, both failed with the username_taken error
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/account/registration/username-selection.react.js | ||
|---|---|---|
| 95–97 ↗ | (On Diff #38047) | As a follow up, it'd be good to create a wrapper over commRustModule.findUserIDFor___() which returns proper flow-typed FindUserIDResponse = { +userID: string; +isReserved: boolean }, optionally also checked with a validator. |
| native/account/registration/username-selection.react.js | ||
|---|---|---|
| 95–97 ↗ | (On Diff #38047) | @varun can you create a task for this? I wonder if it should be in IdentityServiceClient |
| 104 ↗ | (On Diff #38047) | It looks like this logic changed. If you're sure it's okay to change, you can leave as-is. I haven't dug into whether this change is okay, but it would be really simple to just keep the old logic |
| native/account/registration/username-selection.react.js | ||
|---|---|---|
| 95–97 ↗ | (On Diff #38047) | |