refactor integrity reducer starting state to use processStoreOps
ClosedPublic
Actions

Authored by will on Mar 13 2024, 11:27 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM2107c0a14ea4: refactor integrity reducer starting state to use processStoreOps

Summary

This refactors the integrity reducer starting state to use processStoreOps. If empty state, we should generate a remove_all_integrity_thread_hashes op.

More context: https://phab.comm.dev/D11287

Depends on D11298

Test Plan

flow check

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Mar 13 2024, 11:27 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 13 2024, 11:27 PM

will edited the summary of this revision. (Show Details)Mar 13 2024, 11:33 PM

will added a child revision: D11323: [lib] return ops from integrity store reducer.

will edited the summary of this revision. (Show Details)Mar 13 2024, 11:37 PM

will added a parent revision: D11298: [lib] Refactor integrity reducer to process threadStore ops with sqlite ops.

Harbormaster completed remote builds in B27492: Diff 38049.Mar 13 2024, 11:42 PM

will requested review of this revision.Mar 13 2024, 11:42 PM

kamil accepted this revision.Mar 18 2024, 6:19 AM

This revision is now accepted and ready to land.Mar 18 2024, 6:19 AM

will added a child revision: D11343: [sqlite] [lib] refactor integrity reducer full state sync action type to use sqlite ops.Mar 18 2024, 6:39 AM

will removed a child revision: D11323: [lib] return ops from integrity store reducer.Mar 25 2024, 1:42 PM

Closed by commit rCOMM2107c0a14ea4: refactor integrity reducer starting state to use processStoreOps (authored by will). · Explain WhyMar 25 2024, 2:11 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM2107c0a14ea4: refactor integrity reducer starting state to use processStoreOps.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

integrity-reducer.js

11 lines

Diff 38049

View Options

lib/reducers/integrity-reducer.js

	Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
	import {			import {
	fullStateSyncActionType,			fullStateSyncActionType,
	incrementalStateSyncActionType,			incrementalStateSyncActionType,
	} from '../types/socket-types.js';			} from '../types/socket-types.js';
	import { threadPermissions } from '../types/thread-permission-types.js';			import { threadPermissions } from '../types/thread-permission-types.js';
	import type {			import type {
	LegacyRawThreadInfo,			LegacyRawThreadInfo,
	MinimallyEncodedRawThreadInfos,			MinimallyEncodedRawThreadInfos,
	RawThreadInfos,			MixedRawThreadInfos,
	} from '../types/thread-types.js';			} from '../types/thread-types.js';
	import {			import {
	type ClientUpdateInfo,			type ClientUpdateInfo,
	processUpdatesActionType,			processUpdatesActionType,
	} from '../types/update-types.js';			} from '../types/update-types.js';
	import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';			import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';

	const _mapValuesWithKeys = _mapValues.convert({ cap: false });			const _mapValuesWithKeys = _mapValues.convert({ cap: false });
	Show All 35 Lines
	type FreshMessageStoreResult = {			type FreshMessageStoreResult = {
	+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,			+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
	+messageStore: MessageStore,			+messageStore: MessageStore,
	};			};
	function freshMessageStore(			function freshMessageStore(
	messageInfos: $ReadOnlyArray<RawMessageInfo>,			messageInfos: $ReadOnlyArray<RawMessageInfo>,
	truncationStatus: { [threadID: string]: MessageTruncationStatus },			truncationStatus: { [threadID: string]: MessageTruncationStatus },
	currentAsOf: { +[keyserverID: string]: number },			currentAsOf: { +[keyserverID: string]: number },
	threadInfos: RawThreadInfos,			threadInfos: MixedRawThreadInfos,
	): FreshMessageStoreResult {			): FreshMessageStoreResult {
	const unshimmed = unshimMessageInfos(messageInfos);			const unshimmed = unshimMessageInfos(messageInfos);
	const orderedMessageInfos = sortMessageInfoList(unshimmed);			const orderedMessageInfos = sortMessageInfoList(unshimmed);
	const messages = _keyBy(messageID)(orderedMessageInfos);			const messages = _keyBy(messageID)(orderedMessageInfos);

	const messageStoreReplaceOperations = orderedMessageInfos.map(			const messageStoreReplaceOperations = orderedMessageInfos.map(
	messageInfo => ({			messageInfo => ({
	type: 'replace',			type: 'replace',
	▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines

refactor integrity reducer starting state to use processStoreOpsClosedPublicActions