Page MenuHomePhabricator
Differential D11329

[identity] Update invalid username check on Identity service
ClosedPublic
Actions

Authored by varun on Mar 14 2024, 8:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 27 2025, 7:27 PM
Unknown Object (File)
Feb 27 2025, 7:27 PM
Unknown Object (File)
Feb 27 2025, 8:45 AM
Unknown Object (File)
Feb 26 2025, 7:18 AM
Unknown Object (File)
Feb 26 2025, 7:15 AM
Unknown Object (File)
Feb 23 2025, 3:21 AM
Unknown Object (File)
Jan 20 2025, 3:54 AM
Unknown Object (File)
Jan 19 2025, 6:04 AM
View All 90 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
michal
will
Commits
rCOMMf3c665ffa54b: [identity] Update invalid username check on Identity service
Summary
  1. check that the username is valid (no invalid special characters, min length 1, max length 191, starts with alphanumeric character)
  2. return invalid username error instead of username reserved error if username is a valid eth address
Test Plan
  1. unit tests
  2. used commtest to try registering various invalid usernames, confirmed that i got an invalid username response from identity each time

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
identity/
src/
12 lines
5 lines
1 line
54 lines

Diff 38085

View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines return facebook::react::createPromiseAsJSIValue(
DatabaseManager::getQueryExecutor().beginTransaction(); DatabaseManager::getQueryExecutor().beginTransaction();
for (const auto &operation : *storeOpsPtr) { for (const auto &operation : *storeOpsPtr) {
operation->execute(); operation->execute();
} }
if (messages.size() > 0) { if (messages.size() > 0) {
DatabaseManager::getQueryExecutor().addOutboundP2PMessages( DatabaseManager::getQueryExecutor().addOutboundP2PMessages(
messages); messages);
} }
DatabaseManager::getQueryExecutor().captureBackupLogs();
DatabaseManager::getQueryExecutor().commitTransaction(); DatabaseManager::getQueryExecutor().commitTransaction();
} catch (std::system_error &e) { } catch (std::system_error &e) {
error = e.what(); error = e.what();
DatabaseManager::getQueryExecutor().rollbackTransaction(); DatabaseManager::getQueryExecutor().rollbackTransaction();
} }
} }
if (!error.size()) {
DatabaseManager::getQueryExecutor().triggerBackupFileUpload();
}
this->jsInvoker_->invokeAsync([=]() { this->jsInvoker_->invokeAsync([=]() {
if (error.size()) { if (error.size()) {
promise->reject(error); promise->reject(error);
} else { } else {
promise->resolve(jsi::Value::undefined()); promise->resolve(jsi::Value::undefined());
} }
}); });
}; };
▲ Show 20 Lines • Show All 2,995 Lines • Show Last 20 Lines
View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines return facebook::react::createPromiseAsJSIValue(
DatabaseManager::getQueryExecutor().beginTransaction(); DatabaseManager::getQueryExecutor().beginTransaction();
for (const auto &operation : *storeOpsPtr) { for (const auto &operation : *storeOpsPtr) {
operation->execute(); operation->execute();
} }
if (messages.size() > 0) { if (messages.size() > 0) {
DatabaseManager::getQueryExecutor().addOutboundP2PMessages( DatabaseManager::getQueryExecutor().addOutboundP2PMessages(
messages); messages);
} }
DatabaseManager::getQueryExecutor().captureBackupLogs();
DatabaseManager::getQueryExecutor().commitTransaction(); DatabaseManager::getQueryExecutor().commitTransaction();
} catch (std::system_error &e) { } catch (std::system_error &e) {
error = e.what(); error = e.what();
DatabaseManager::getQueryExecutor().rollbackTransaction(); DatabaseManager::getQueryExecutor().rollbackTransaction();
} }
} }
if (!error.size()) {
DatabaseManager::getQueryExecutor().triggerBackupFileUpload();
}
this->jsInvoker_->invokeAsync([=]() { this->jsInvoker_->invokeAsync([=]() {
if (error.size()) { if (error.size()) {
promise->reject(error); promise->reject(error);
} else { } else {
promise->resolve(jsi::Value::undefined()); promise->resolve(jsi::Value::undefined());
} }
}); });
}; };
▲ Show 20 Lines • Show All 2,995 Lines • Show Last 20 Lines
View Options

services/identity/src/main.rs

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines return facebook::react::createPromiseAsJSIValue(
DatabaseManager::getQueryExecutor().beginTransaction(); DatabaseManager::getQueryExecutor().beginTransaction();
for (const auto &operation : *storeOpsPtr) { for (const auto &operation : *storeOpsPtr) {
operation->execute(); operation->execute();
} }
if (messages.size() > 0) { if (messages.size() > 0) {
DatabaseManager::getQueryExecutor().addOutboundP2PMessages( DatabaseManager::getQueryExecutor().addOutboundP2PMessages(
messages); messages);
} }
DatabaseManager::getQueryExecutor().captureBackupLogs();
DatabaseManager::getQueryExecutor().commitTransaction(); DatabaseManager::getQueryExecutor().commitTransaction();
} catch (std::system_error &e) { } catch (std::system_error &e) {
error = e.what(); error = e.what();
DatabaseManager::getQueryExecutor().rollbackTransaction(); DatabaseManager::getQueryExecutor().rollbackTransaction();
} }
} }
if (!error.size()) {
DatabaseManager::getQueryExecutor().triggerBackupFileUpload();
}
this->jsInvoker_->invokeAsync([=]() { this->jsInvoker_->invokeAsync([=]() {
if (error.size()) { if (error.size()) {
promise->reject(error); promise->reject(error);
} else { } else {
promise->resolve(jsi::Value::undefined()); promise->resolve(jsi::Value::undefined());
} }
}); });
}; };
▲ Show 20 Lines • Show All 2,995 Lines • Show Last 20 Lines
View Options

services/identity/src/regex.rs

Show First 20 Lines • Show All 531 Lines • ▼ Show 20 Lines return facebook::react::createPromiseAsJSIValue(
DatabaseManager::getQueryExecutor().beginTransaction(); DatabaseManager::getQueryExecutor().beginTransaction();
for (const auto &operation : *storeOpsPtr) { for (const auto &operation : *storeOpsPtr) {
operation->execute(); operation->execute();
} }
if (messages.size() > 0) { if (messages.size() > 0) {
DatabaseManager::getQueryExecutor().addOutboundP2PMessages( DatabaseManager::getQueryExecutor().addOutboundP2PMessages(
messages); messages);
} }
DatabaseManager::getQueryExecutor().captureBackupLogs();
DatabaseManager::getQueryExecutor().commitTransaction(); DatabaseManager::getQueryExecutor().commitTransaction();
} catch (std::system_error &e) { } catch (std::system_error &e) {
error = e.what(); error = e.what();
DatabaseManager::getQueryExecutor().rollbackTransaction(); DatabaseManager::getQueryExecutor().rollbackTransaction();
} }
} }
if (!error.size()) {
DatabaseManager::getQueryExecutor().triggerBackupFileUpload();
}
this->jsInvoker_->invokeAsync([=]() { this->jsInvoker_->invokeAsync([=]() {
if (error.size()) { if (error.size()) {
promise->reject(error); promise->reject(error);
} else { } else {
promise->resolve(jsi::Value::undefined()); promise->resolve(jsi::Value::undefined());
} }
}); });
}; };
▲ Show 20 Lines • Show All 2,995 Lines • Show Last 20 Lines