Page MenuHomePhabricator
Differential D11368

[native][web] Remove processing the ops from reducers
ClosedPublic
Actions

Authored by tomek on Mar 21 2024, 8:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 12:42 AM
Unknown Object (File)
Thu, Mar 20, 5:00 AM
Unknown Object (File)
Feb 26 2025, 11:39 AM
Unknown Object (File)
Feb 26 2025, 11:39 AM
Unknown Object (File)
Feb 26 2025, 11:39 AM
Unknown Object (File)
Feb 26 2025, 11:39 AM
Unknown Object (File)
Feb 26 2025, 11:34 AM
Unknown Object (File)
Feb 18 2025, 7:55 PM
View All Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
will
Commits
rCOMM6c78d160c2b4: [native][web] Remove processing the ops from reducers
Summary

We no longer need to process the ops in reducers because the new handler handles that.

https://linear.app/comm/issue/ENG-7099/stop-processing-the-ops-in-master-reducers

Depends on D11367

Test Plan

Check if the changes are persisted in the db - by e.g. checking if the drafts remain present after restarting the app.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Mar 21 2024, 8:23 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMar 21 2024, 8:23 AM
tomek added a child revision: D11369: [lib] Create a wrapper over dispatch.Mar 21 2024, 8:26 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2024, 8:34 AM
Harbormaster failed remote builds in B27649: Diff 38270!
tomek updated this revision to Diff 38372.Mar 27 2024, 8:59 AM

Rebase

Harbormaster completed remote builds in B27709: Diff 38372.Mar 27 2024, 9:15 AM
tomek requested review of this revision.Mar 27 2024, 9:15 AM
ashoat added inline comments.Mar 27 2024, 5:15 PM
web/redux/redux-setup.js
490–501 ↗(On Diff #38372)

Nit: to me it feels like it would be more clear to invert this condition now

kamil accepted this revision.Mar 28 2024, 3:52 AM
kamil added inline comments.
web/redux/redux-setup.js
371 ↗(On Diff #38372)

we can rename it now to reflect changes

This revision is now accepted and ready to land.Mar 28 2024, 3:52 AM
tomek updated this revision to Diff 38436.Mar 28 2024, 4:59 AM

Rename and invert a condition

Harbormaster completed remote builds in B27758: Diff 38436.Mar 28 2024, 5:14 AM
Closed by commit rCOMM6c78d160c2b4: [native][web] Remove processing the ops from reducers (authored by tomek). · Explain WhyMar 28 2024, 8:11 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM6c78d160c2b4: [native][web] Remove processing the ops from reducers.

Revision Contents
Changeset List

PathSize
native/
redux/
3 lines
web/
redux/
31 lines

Diff 38458

View Options

native/redux/redux-setup.js

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines
View Options

web/redux/redux-setup.js

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
import type { import type {
ConnectionIssue, ConnectionIssue,
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type {
AddSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload,
} from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
ThreadJoinPayload, ThreadJoinPayload,
▲ Show 20 Lines • Show All 1,239 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload,
}
| {
+type: 'REMOVE_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload,
}
| {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE', +type: 'OPS_PROCESSING_FINISHED_ACTION_TYPE',
+payload?: void, +payload?: void,
}, },
}>; }>;
Show All 21 Lines