Differential D11368

[native][web] Remove processing the ops from reducers
ClosedPublic
Actions

Authored by tomek on Mar 21 2024, 8:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 6, 7:53 AM

	Unknown Object (File)
	Thu, Apr 3, 12:23 AM

	Unknown Object (File)
	Wed, Mar 26, 12:42 AM

	Unknown Object (File)
	Thu, Mar 20, 5:00 AM

	Unknown Object (File)
	Feb 26 2025, 11:39 AM

	Unknown Object (File)
	Feb 26 2025, 11:39 AM

	Unknown Object (File)
	Feb 26 2025, 11:39 AM

	Unknown Object (File)
	Feb 26 2025, 11:39 AM

Subscribers

Details

Reviewers

kamil
inka
will

Commits

rCOMM6c78d160c2b4: [native][web] Remove processing the ops from reducers

Summary

We no longer need to process the ops in reducers because the new handler handles that.

https://linear.app/comm/issue/ENG-7099/stop-processing-the-ops-in-master-reducers

Depends on D11367

Test Plan

Check if the changes are persisted in the db - by e.g. checking if the drafts remain present after restarting the app.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 21 2024, 8:23 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 21 2024, 8:23 AM

tomek added a child revision: D11369: [lib] Create a wrapper over dispatch.Mar 21 2024, 8:26 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2024, 8:34 AM

Harbormaster failed remote builds in B27649: Diff 38270!

Rebase

Harbormaster completed remote builds in B27709: Diff 38372.Mar 27 2024, 9:15 AM

tomek requested review of this revision.Mar 27 2024, 9:15 AM

ashoat added inline comments.Mar 27 2024, 5:15 PM

web/redux/redux-setup.js
490–501 ↗	(On Diff #38372)	Nit: to me it feels like it would be more clear to invert this condition now

kamil accepted this revision.Mar 28 2024, 3:52 AM

kamil added inline comments.

web/redux/redux-setup.js
371 ↗	(On Diff #38372)	we can rename it now to reflect changes

This revision is now accepted and ready to land.Mar 28 2024, 3:52 AM

Rename and invert a condition

Harbormaster completed remote builds in B27758: Diff 38436.Mar 28 2024, 5:14 AM

Closed by commit rCOMM6c78d160c2b4: [native][web] Remove processing the ops from reducers (authored by tomek). · Explain WhyMar 28 2024, 8:11 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM6c78d160c2b4: [native][web] Remove processing the ops from reducers.

Revision Contents
Changeset List

Path

Size

native/

redux/

3 lines

web/

redux/

31 lines

Diff 38458

native/redux/redux-setup.js

This file was added.

				// @flow

				import * as React from 'react';

				import { DBOpsHandler as BaseHandler } from 'lib/handlers/db-ops-handler.react.js';
				import type { StoreOperations } from 'lib/types/store-ops-types.js';

				import { useSelector } from '../redux/redux-utils.js';
				import { processDBStoreOperations } from '../shared-worker/utils/store.js';

				function DBOpsHandler(): React.Node {
				const currentUserID = useSelector(state => state.currentUserInfo?.id ?? null);
				const processOperations = React.useCallback(
				(ops: StoreOperations) => processDBStoreOperations(ops, currentUserID),
				[currentUserID],
				);
				return <BaseHandler processDBStoreOperations={processOperations} />;
				}

				export { DBOpsHandler };

web/redux/redux-setup.js

This file was added.

				// @flow

				import * as React from 'react';

				import { DBOpsHandler as BaseHandler } from 'lib/handlers/db-ops-handler.react.js';
				import type { StoreOperations } from 'lib/types/store-ops-types.js';

				import { useSelector } from '../redux/redux-utils.js';
				import { processDBStoreOperations } from '../shared-worker/utils/store.js';

				function DBOpsHandler(): React.Node {
				const currentUserID = useSelector(state => state.currentUserInfo?.id ?? null);
				const processOperations = React.useCallback(
				(ops: StoreOperations) => processDBStoreOperations(ops, currentUserID),
				[currentUserID],
				);
				return <BaseHandler processDBStoreOperations={processOperations} />;
				}

				export { DBOpsHandler };