Details

Reviewers

kamil
inka
will

Commits

rCOMMbac8331a77bc: [lib] Add a reducer that handles successful ops processing

Summary

Remove the front of the queue when we are noticed that the processing was successful

https://linear.app/comm/issue/ENG-7102/reduce-the-action-this-should-filter-the-ops-out-from-the-array

Depends on D11279

Test Plan

Tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 8 2024, 9:00 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMar 8 2024, 9:00 AM

Harbormaster completed remote builds in B27398: Diff 37942.Mar 8 2024, 9:16 AM

tomek requested review of this revision.Mar 8 2024, 9:16 AM

tomek added a child revision: D11281: [lib] Add an optional ID field to all the actions.Mar 8 2024, 10:28 AM

kamil accepted this revision.Mar 11 2024, 11:13 AM

kamil added inline comments.

lib/reducers/db-ops-reducer.js
7 ↗	(On Diff #37942)

This revision is now accepted and ready to land.Mar 11 2024, 11:13 AM

Rename, rebase

Harbormaster completed remote builds in B27640: Diff 38261.Mar 21 2024, 12:19 PM

Simplify reducer logic

Harbormaster completed remote builds in B27645: Diff 38266.Mar 21 2024, 3:23 PM

Simplify

tomek edited the summary of this revision. (Show Details)Mar 27 2024, 3:47 PM

Harbormaster completed remote builds in B27704: Diff 38367.Mar 27 2024, 4:01 PM

Closed by commit rCOMMbac8331a77bc: [lib] Add a reducer that handles successful ops processing. · Explain WhyMar 28 2024, 3:11 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMbac8331a77bc: [lib] Add a reducer that handles successful ops processing.

[lib] Add a reducer that handles successful ops processing
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 38453

lib/reducers/db-ops-reducer.js

lib/reducers/db-ops-reducer.test.js

lib/reducers/master-reducer.js

[lib] Add a reducer that handles successful ops processingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38453

lib/reducers/db-ops-reducer.js

lib/reducers/db-ops-reducer.test.js

lib/reducers/master-reducer.js

[lib] Add a reducer that handles successful ops processing
ClosedPublic
Actions

Revision Contents
Changeset List