[native] Export `neynarKey` so it's accessible from `native`
ClosedPublic
Actions

Authored by atul on Mar 25 2024, 1:08 PM.

Details

Reviewers

ashoat
ginsu
tomek
will
varun

Commits

rCOMMbbaa364113d8: [native] Export `neynarKey` so it's accessible from `native`

Summary

Making neynarKey in native/facts available throughout native app.

Test Plan

Imported neynarKey in PrivacyPreferences
Displayed neynarKey in Text component and ensured it was as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 25 2024, 1:08 PM

atul added a child revision: D11381: [CI] Include "Save NEYNAR_API_KEY to file" step in `[ios/android]_release` workflows.Mar 25 2024, 1:16 PM

Harbormaster completed remote builds in B27669: Diff 38301.Mar 25 2024, 1:23 PM

atul requested review of this revision.Mar 25 2024, 1:23 PM

One question inline

native/utils/neynar-utils.js
8 ↗	(On Diff #38301)	Should we log this error so that it is obvious if this file is missing?

This revision is now accepted and ready to land.Mar 25 2024, 1:25 PM

address feedback

Harbormaster completed remote builds in B27686: Diff 38340.Mar 26 2024, 11:20 AM

Closed by commit rCOMMbbaa364113d8: [native] Export `neynarKey` so it's accessible from `native` (authored by atul). · Explain WhyMar 26 2024, 12:00 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbbaa364113d8: [native] Export `neynarKey` so it's accessible from `native`.

Revision Contents
Changeset List

Path

Size

native/

utils/

neynar-utils.js

12 lines

Diff 38341

View Options

native/utils/neynar-utils.js

This is a binary file.

[native] Export `neynarKey` so it's accessible from `native`ClosedPublicActions