Page MenuHomePhabricator

[lib][native] FIDProvider
ClosedPublic

Authored by ashoat on Mar 27 2024, 5:47 PM.
Tags
None
Referenced Files
F1668743: D11425.id.diff
Sat, Apr 27, 2:19 AM
Unknown Object (File)
Sat, Apr 6, 5:02 PM
Unknown Object (File)
Fri, Apr 5, 1:25 PM
Unknown Object (File)
Wed, Apr 3, 7:39 PM
Unknown Object (File)
Wed, Apr 3, 3:41 PM
Unknown Object (File)
Tue, Apr 2, 5:00 PM
Unknown Object (File)
Tue, Apr 2, 11:39 AM
Unknown Object (File)
Sat, Mar 30, 6:24 PM
Subscribers

Details

Summary

During the Hackathon, this commit enabled us to temporarily store the FID in a context while @will's work on the synced metadata store was in progress.

Since this context is temporary, we considered not diffing it up. Decided against that for two reasons:

  1. Putting this diff up allows others to put up diffs while the synced metadata stack (ending in D11424) is pending review.
  2. Putting this diff up allows the team to put up existing commits as diffs with minimal modifications.

@will said he'd create a task to cover replacing all FIDProvider usages with the synced metadata store. Would be good to mention reverting this diff there as well.

Test Plan

Tested in combination with the rest of the farcaster branch

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable