Revert "[native][web] Read integrity thread hashes from SQLite on app start"
AbandonedPublic
Actions

Authored by will on Mar 28 2024, 6:08 PM.

Details

Reviewers

ashoat
ginsu
atul

Summary

This reverts commit 5695216e237f08eae63e3c845481ab791528b18e.

Depends on D11456

Test Plan

Reverts reading sqlite on app start to fix an urgent issue with compiling on native

Context: https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Mar 28 2024, 6:08 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 28 2024, 6:08 PM

will edited the summary of this revision. (Show Details)Mar 28 2024, 6:10 PM

will added a parent revision: D11454: [sqlite] downgrade migration version on native from '65' to '64'.

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 6:19 PM

Harbormaster failed remote builds in B27791: Diff 38486!

rebase

will edited the summary of this revision. (Show Details)Mar 28 2024, 6:27 PM

will added a parent revision: D11456: Revert "[lib] integrity reducer tests".

Harbormaster completed remote builds in B27795: Diff 38490.Mar 28 2024, 6:42 PM

will requested review of this revision.Mar 28 2024, 6:42 PM

ashoat accepted this revision.Mar 28 2024, 6:46 PM

This revision is now accepted and ready to land.Mar 28 2024, 6:46 PM

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved

Revision Contents
Changeset List

Path

Size

lib/

reducers/

integrity-reducer.js

41 lines

master-reducer.js

1 line

message-reducer.test.js

1 line

types/

store-ops-types.js

2 lines

native/

data/

sqlite-data-handler.js

7 lines

web/

shared-worker/

utils/

store.js

9 lines

Diff 38490

View Options

lib/reducers/integrity-reducer.js

View Options

lib/reducers/master-reducer.js

View Options

lib/reducers/message-reducer.test.js

View Options

lib/types/store-ops-types.js

View Options

native/data/sqlite-data-handler.js

View Options

web/shared-worker/utils/store.js

Revert "[native][web] Read integrity thread hashes from SQLite on app start"AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38490

lib/reducers/integrity-reducer.js

lib/reducers/master-reducer.js

lib/reducers/message-reducer.test.js

lib/types/store-ops-types.js

native/data/sqlite-data-handler.js

web/shared-worker/utils/store.js

Revert "[native][web] Read integrity thread hashes from SQLite on app start"
AbandonedPublic
Actions

Revision Contents
Changeset List