Page MenuHomePhabricator
Differential D11453

Revert "[native][web] Read integrity thread hashes from SQLite on app start"
AbandonedPublic
Actions

Authored by will on Mar 28 2024, 11:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 22, 5:35 AM
Unknown Object (File)
Mon, Mar 17, 3:03 PM
Unknown Object (File)
Sat, Mar 15, 1:46 PM
Unknown Object (File)
Feb 27 2025, 3:02 PM
Unknown Object (File)
Feb 26 2025, 9:24 PM
Unknown Object (File)
Feb 20 2025, 10:30 AM
Unknown Object (File)
Jan 28 2025, 4:21 PM
Unknown Object (File)
Jan 28 2025, 4:21 PM
View All 62 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
atul
Summary

This reverts commit 5695216e237f08eae63e3c845481ab791528b18e.

Depends on D11456

Test Plan

Reverts reading sqlite on app start to fix an urgent issue with compiling on native

Context: https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Mar 28 2024, 11:08 AM
Herald added a subscriber: tomek. · View Herald TranscriptMar 28 2024, 11:08 AM
will edited the summary of this revision. (Show Details)Mar 28 2024, 11:10 AM
will added a parent revision: D11454: [sqlite] downgrade migration version on native from '65' to '64'.
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 28 2024, 11:19 AM
Harbormaster failed remote builds in B27791: Diff 38486!
will updated this revision to Diff 38490.Mar 28 2024, 11:26 AM
will edited the summary of this revision. (Show Details)

rebase

will edited the summary of this revision. (Show Details)Mar 28 2024, 11:27 AM
will added a parent revision: D11456: Revert "[lib] integrity reducer tests".
Harbormaster completed remote builds in B27795: Diff 38490.Mar 28 2024, 11:42 AM
will requested review of this revision.Mar 28 2024, 11:42 AM
ashoat accepted this revision.Mar 28 2024, 11:46 AM
This revision is now accepted and ready to land.Mar 28 2024, 11:46 AM
will abandoned this revision.Mar 28 2024, 1:48 PM

https://linear.app/comm/issue/ENG-7597/app-crashes-when-running-migration-65#comment-8b4375fe resolved

Revision Contents
Changeset List

PathSize
lib/
reducers/
41 lines
1 line
1 line
types/
2 lines
native/
data/
7 lines
web/
shared-worker/
utils/
9 lines

Diff 38490

View Options

lib/reducers/integrity-reducer.js

Show All 14 Linesimport {
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { import {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Linesclass App extends React.PureComponent<Props> {
render(): React.Node { render(): React.Node {
let content; let content;
if (this.props.loggedIn) { if (this.props.loggedIn) {
content = ( content = (
<> <>
<WebEditThreadAvatarProvider> <WebEditThreadAvatarProvider>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<StaffContextProvider>
{this.renderMainContent()} {this.renderMainContent()}
{this.props.modals} {this.props.modals}
</StaffContextProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</WebEditThreadAvatarProvider> </WebEditThreadAvatarProvider>
</> </>
); );
} else { } else {
content = ( content = (
<> <>
{this.renderLoginPage()} {this.renderLoginPage()}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines
View Options

lib/reducers/master-reducer.js

Show All 14 Linesimport {
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { import {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Linesclass App extends React.PureComponent<Props> {
render(): React.Node { render(): React.Node {
let content; let content;
if (this.props.loggedIn) { if (this.props.loggedIn) {
content = ( content = (
<> <>
<WebEditThreadAvatarProvider> <WebEditThreadAvatarProvider>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<StaffContextProvider>
{this.renderMainContent()} {this.renderMainContent()}
{this.props.modals} {this.props.modals}
</StaffContextProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</WebEditThreadAvatarProvider> </WebEditThreadAvatarProvider>
</> </>
); );
} else { } else {
content = ( content = (
<> <>
{this.renderLoginPage()} {this.renderLoginPage()}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines
View Options

lib/reducers/message-reducer.test.js

Show All 14 Linesimport {
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { import {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Linesclass App extends React.PureComponent<Props> {
render(): React.Node { render(): React.Node {
let content; let content;
if (this.props.loggedIn) { if (this.props.loggedIn) {
content = ( content = (
<> <>
<WebEditThreadAvatarProvider> <WebEditThreadAvatarProvider>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<StaffContextProvider>
{this.renderMainContent()} {this.renderMainContent()}
{this.props.modals} {this.props.modals}
</StaffContextProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</WebEditThreadAvatarProvider> </WebEditThreadAvatarProvider>
</> </>
); );
} else { } else {
content = ( content = (
<> <>
{this.renderLoginPage()} {this.renderLoginPage()}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines
View Options

lib/types/store-ops-types.js

Show All 14 Linesimport {
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { import {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Linesclass App extends React.PureComponent<Props> {
render(): React.Node { render(): React.Node {
let content; let content;
if (this.props.loggedIn) { if (this.props.loggedIn) {
content = ( content = (
<> <>
<WebEditThreadAvatarProvider> <WebEditThreadAvatarProvider>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<StaffContextProvider>
{this.renderMainContent()} {this.renderMainContent()}
{this.props.modals} {this.props.modals}
</StaffContextProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</WebEditThreadAvatarProvider> </WebEditThreadAvatarProvider>
</> </>
); );
} else { } else {
content = ( content = (
<> <>
{this.renderLoginPage()} {this.renderLoginPage()}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines
View Options

native/data/sqlite-data-handler.js

Show All 14 Linesimport {
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { import {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Linesclass App extends React.PureComponent<Props> {
render(): React.Node { render(): React.Node {
let content; let content;
if (this.props.loggedIn) { if (this.props.loggedIn) {
content = ( content = (
<> <>
<WebEditThreadAvatarProvider> <WebEditThreadAvatarProvider>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<StaffContextProvider>
{this.renderMainContent()} {this.renderMainContent()}
{this.props.modals} {this.props.modals}
</StaffContextProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</WebEditThreadAvatarProvider> </WebEditThreadAvatarProvider>
</> </>
); );
} else { } else {
content = ( content = (
<> <>
{this.renderLoginPage()} {this.renderLoginPage()}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines
View Options

web/shared-worker/utils/store.js

Show All 14 Linesimport {
updateCalendarQueryActionTypes, updateCalendarQueryActionTypes,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { import {
ModalProvider, ModalProvider,
useModalContext, useModalContext,
} from 'lib/components/modal-provider.react.js'; } from 'lib/components/modal-provider.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { import {
createLoadingStatusSelector, createLoadingStatusSelector,
combineLoadingStatuses, combineLoadingStatuses,
} from 'lib/selectors/loading-selectors.js'; } from 'lib/selectors/loading-selectors.js';
import { isLoggedIn } from 'lib/selectors/user-selectors.js'; import { isLoggedIn } from 'lib/selectors/user-selectors.js';
import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js'; import { extractMajorDesktopVersion } from 'lib/shared/version-utils.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 153 Lines • ▼ Show 20 Linesclass App extends React.PureComponent<Props> {
render(): React.Node { render(): React.Node {
let content; let content;
if (this.props.loggedIn) { if (this.props.loggedIn) {
content = ( content = (
<> <>
<WebEditThreadAvatarProvider> <WebEditThreadAvatarProvider>
<EditUserAvatarProvider> <EditUserAvatarProvider>
<StaffContextProvider>
{this.renderMainContent()} {this.renderMainContent()}
{this.props.modals} {this.props.modals}
</StaffContextProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</WebEditThreadAvatarProvider> </WebEditThreadAvatarProvider>
</> </>
); );
} else { } else {
content = ( content = (
<> <>
{this.renderLoginPage()} {this.renderLoginPage()}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines