Page MenuHomePhabricator
Differential D11466

[identity] Implement LogInExistingDevice RPC
ClosedPublic
Actions

Authored by bartek on Mar 28 2024, 10:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 1:18 PM
Unknown Object (File)
Tue, May 7, 1:18 PM
Unknown Object (File)
Tue, May 7, 1:17 PM
Unknown Object (File)
Tue, May 7, 1:16 PM
Unknown Object (File)
Thu, Apr 11, 5:34 PM
Unknown Object (File)
Apr 8 2024, 10:09 AM
Unknown Object (File)
Apr 5 2024, 4:28 AM
Unknown Object (File)
Apr 3 2024, 4:27 PM
View All 13 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM0aacce933929: [identity] Implement LogInExistingDevice RPC
Summary

Implementation of the LogInExistingDevice RPC. Its purpose is to:

  • verify nonce challenge
  • check if device being logged in is on the device list
  • generate access token for the device

Depends on D11465

Test Plan
  1. Registered a device - received a CSAT (1)
  2. Called the LogInExistingDevice RPC - Received a CSAT (2)
  3. Called VerifyUserAccessToken RPC for both CSATs - (2) is valid, (1) is no longer valid

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Mar 28 2024, 10:45 PM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 28 2024, 10:45 PM
Harbormaster failed remote builds in B27808: Diff 38525!Mar 28 2024, 10:46 PM
bartek added a child revision: D11468: [commtest] Add test for LogInExistingDevice RPC.Mar 28 2024, 10:47 PM
bartek added a child revision: D11469: [native] Add LogInExistingDevice to native_rust_library.Mar 28 2024, 11:02 PM
bartek mentioned this in D11470: [native] Add JSI bindings for LogInExistingDevice RPC.Mar 28 2024, 11:04 PM
Harbormaster completed remote builds in B27808: Diff 38525.Mar 28 2024, 11:58 PM
bartek published this revision for review.Mar 29 2024, 12:11 AM
varun accepted this revision.Apr 1 2024, 9:28 PM
This revision is now accepted and ready to land.Apr 1 2024, 9:28 PM
Closed by commit rCOMM0aacce933929: [identity] Implement LogInExistingDevice RPC (authored by bartek). · Explain WhyApr 3 2024, 3:17 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM0aacce933929: [identity] Implement LogInExistingDevice RPC.
bartek mentioned this in rCOMM70ffc9f4131d: [native] Add JSI bindings for LogInExistingDevice RPC.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
52 lines
15 lines

Diff 38711

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/grpc_utils.rs

Loading...