[sqlite] Add keyservers_synced_data table
ClosedPublic
Actions

Authored by michal on Mar 29 2024, 7:22 AM.

Details

Reviewers

kamil
marcin

Commits

rCOMM80d5601d449e: [sqlite] Add keyservers_synced_data table

Summary

Part of ENG-6927 : Stop backing up device specific data in keyserverStore

Because we only want to back up part of keyserver store, the easiest way to implement this is to create a separate table and backup only one them. This table creates the new keyservers_synced_data table.

Depends on D11472

Test Plan

Run migration on web and native, make sure the table is created.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Mar 29 2024, 7:22 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 29 2024, 7:22 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 29 2024, 7:34 AM

Harbormaster failed remote builds in B27820: Diff 38541!

Update wasm

michal added a child revision: D11481: [sqlite/lib] Split keyserver ops for backed and non-backed up data.Mar 29 2024, 1:43 PM

Harbormaster completed remote builds in B27828: Diff 38555.Mar 29 2024, 1:52 PM

michal requested review of this revision.Mar 29 2024, 1:52 PM

Are we sure that we will never want to inspect the content of keyserver_info values stored in keyserver_synced_data in C++? I am basically asking about the risk that we will have to manually parse JSON-strings in C++ in future.

This revision is now accepted and ready to land.Apr 2 2024, 3:08 AM

Just for clarity - could you link diff where keyservers is added to the backup blacklist?

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
686 ↗	(On Diff #38555)	nit: this seems more readable but up to you

Rename table

Just for clarity - could you link diff where keyservers is added to the backup blacklist?

D11482

Are we sure that we will never want to inspect the content of keyserver_info values stored in keyserver_synced_data in C++?

I think we have been using this approach already and it's been working pretty well. I think it's worth it as it also makes the JS handling of data easier, and changes to schema don't require native code modifications.

Harbormaster completed remote builds in B27937: Diff 38716.Apr 3 2024, 4:16 AM

Closed by commit rCOMM80d5601d449e: [sqlite] Add keyservers_synced_data table (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyApr 4 2024, 8:25 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM80d5601d449e: [sqlite] Add keyservers_synced_data table.