Page MenuHomePhabricator
Differential D11488

[native] Allow us to open a bunch of other wallets
ClosedPublic
Actions

Authored by ashoat on Mar 30 2024, 3:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 11:41 PM
Unknown Object (File)
Wed, Feb 26, 11:38 AM
Unknown Object (File)
Wed, Feb 26, 11:38 AM
Unknown Object (File)
Wed, Feb 26, 11:35 AM
Unknown Object (File)
Jan 24 2025, 7:13 AM
Unknown Object (File)
Jan 24 2025, 7:13 AM
Unknown Object (File)
Jan 24 2025, 7:12 AM
Unknown Object (File)
Jan 23 2025, 11:46 PM
View All 68 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMe424a719919b: [native] Allow us to open a bunch of other wallets
Summary

The WalletConnect react-native-examples repo has this list. Their docs have these instructions.

Test Plan

Confirmed that this fixes redirect to the Metamask wallet on native

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 30 2024, 3:21 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 30 2024, 3:21 PM
ashoat added a child revision: D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.Mar 30 2024, 3:23 PM
Harbormaster completed remote builds in B27836: Diff 38569.Mar 30 2024, 3:36 PM
ashoat requested review of this revision.Mar 30 2024, 3:36 PM
ashoat added a child revision: D11493: [buildkite] Update image used in Buildkite JS workflows to Node 20.Mar 30 2024, 3:38 PM
ashoat removed a child revision: D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.Mar 30 2024, 3:39 PM
ashoat added a child revision: D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.Mar 30 2024, 4:01 PM
ashoat removed a child revision: D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.Mar 30 2024, 4:43 PM
ashoat added a child revision: D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.Mar 30 2024, 4:53 PM
ashoat removed a child revision: D11489: [lib][landing][web] Update Rainbowkit, Wagmi, and Viem.Mar 30 2024, 5:30 PM
ginsu accepted this revision.Apr 1 2024, 9:18 AM
This revision is now accepted and ready to land.Apr 1 2024, 9:18 AM
Closed by commit rCOMMe424a719919b: [native] Allow us to open a bunch of other wallets (authored by ashoat). · Explain WhyApr 1 2024, 10:15 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe424a719919b: [native] Allow us to open a bunch of other wallets.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm/
42 lines
42 lines

Diff 38569

View Options

native/ios/Comm/Info.debug.plist

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines +findUserIdentities: (
userIds: $ReadOnlyArray<string>, userIds: $ReadOnlyArray<string>,
) => Promise<UserIdentitiesResponse>, ) => Promise<UserIdentitiesResponse>,
+privilegedDeleteUsers: ( +privilegedDeleteUsers: (
authUserId: string, authUserId: string,
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userIds: $ReadOnlyArray<string>, userIds: $ReadOnlyArray<string>,
) => Promise<void>, ) => Promise<void>,
+syncPlatformDetails: (
userId: string,
deviceId: string,
accessToken: string,
) => Promise<void>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };
View Options

native/ios/Comm/Info.release.plist

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines +findUserIdentities: (
userIds: $ReadOnlyArray<string>, userIds: $ReadOnlyArray<string>,
) => Promise<UserIdentitiesResponse>, ) => Promise<UserIdentitiesResponse>,
+privilegedDeleteUsers: ( +privilegedDeleteUsers: (
authUserId: string, authUserId: string,
authDeviceId: string, authDeviceId: string,
authAccessToken: string, authAccessToken: string,
userIds: $ReadOnlyArray<string>, userIds: $ReadOnlyArray<string>,
) => Promise<void>, ) => Promise<void>,
+syncPlatformDetails: (
userId: string,
deviceId: string,
accessToken: string,
) => Promise<void>,
}; };
export type { RustNativeBindingAPI }; export type { RustNativeBindingAPI };