Paths

Table of Contentst

[protos][identity] Make keyserver_info response non-optional
ClosedPublic
Actions

Authored by bartek on Apr 3 2024, 8:20 AM.

Details

Reviewers

ashoat
varun

Commits

rCOMMd8727804c52e: [protos][identity] Make keyserver_info response non-optional

Summary

Resolves ENG-7598.
We agreed that keyserver_info shouldn't be optional.

Checked native_rust_library code and web identity client. They both already treat this as required so nothing to do client-side

Depends on D11471

Test Plan

Called the GetKeyserverKeys RPC for user without a keyserver - returned "keyserver not found"
Registered a keyserver
Now the RPC responded as before

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Apr 3 2024, 8:20 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptApr 3 2024, 8:20 AM

Update grpc-web type

Harbormaster completed remote builds in B27956: Diff 38736.Apr 3 2024, 8:36 AM

Harbormaster completed remote builds in B27957: Diff 38737.Apr 3 2024, 8:51 AM

bartek published this revision for review.Apr 3 2024, 8:54 AM

varun accepted this revision.Apr 3 2024, 9:21 AM

This revision is now accepted and ready to land.Apr 3 2024, 9:21 AM

bartek added a child revision: D11547: [protos] Refactor user Identity message type.Apr 4 2024, 4:22 AM

Closed by commit rCOMMd8727804c52e: [protos][identity] Make keyserver_info response non-optional (authored by bartek). · Explain WhyApr 8 2024, 3:54 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd8727804c52e: [protos][identity] Make keyserver_info response non-optional.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

grpc_services/

authenticated.rs

8 lines

shared/

protos/

identity_auth.proto

2 lines

web/

protobufs/

identity-auth-structs.cjs.flow

2 lines

Diff 38887

View Options

services/identity/src/grpc_services/authenticated.rs

View Options

shared/protos/identity_auth.proto

View Options

web/protobufs/identity-auth-structs.cjs.flow

[protos][identity] Make keyserver_info response non-optionalClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38887

services/identity/src/grpc_services/authenticated.rs

shared/protos/identity_auth.proto

web/protobufs/identity-auth-structs.cjs.flow

[protos][identity] Make keyserver_info response non-optional
ClosedPublic
Actions

Revision Contents
Changeset List