Paths

Table of Contentst

Differential D11631

[lib] Stop attempting recovery when client version unsupported
ClosedPublic
Actions

Authored by inka on Thu, Apr 11, 5:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 20, 11:13 AM

	Unknown Object (File)
	Thu, Apr 18, 2:51 PM

	Unknown Object (File)
	Tue, Apr 16, 10:00 AM

	Unknown Object (File)
	Thu, Apr 11, 12:46 PM

	Unknown Object (File)
	Thu, Apr 11, 12:44 PM

Subscribers

Details

Reviewers

tomek
ginsu
ashoat

Commits

rCOMMabe65dc59251: [lib] Stop attempting recovery when client version unsupported

Summary

issue: ENG-6125
If the client got client_version_unsupported, a recovery will not help them, so we should skip it. We should just set the session change sent by the server, and a connectionIssue so that other places in the code know what the problem was.

Test Plan

Tested that if the auth keyserver sends client_version_unsupported, then the user is logged out. Checked that a connectionIssue was set, and that triggered the logout.
I tested in the multikeyserver setup, that if the second keyserver sends client_version_unsupported, then the client is not logged out, and a popup shows up. For now, this results in the screen being spammed with popups, because ENG-5913 was not implemented yet (only in case of the secondary keyserver).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Thu, Apr 11, 5:04 AM

Herald added a subscriber: ashoat. · View Herald TranscriptThu, Apr 11, 5:04 AM

inka added a parent revision: D11619: [lib] Add client_version_unsupported connectionIssue.Thu, Apr 11, 5:04 AM

Harbormaster completed remote builds in B28166: Diff 39049.Thu, Apr 11, 5:20 AM

inka requested review of this revision.Thu, Apr 11, 5:20 AM

inka added a child revision: D11632: [lib][web][native] Pass preRequestUserState into invalidSessionRecovery.Thu, Apr 11, 6:06 AM

I can review this one, since I wrote the original code that dispatches setActiveSessionRecoveryActionType

This revision is now accepted and ready to land.Fri, Apr 12, 7:56 AM

Closed by commit rCOMMabe65dc59251: [lib] Stop attempting recovery when client version unsupported (authored by inka). · Explain WhyTue, Apr 16, 5:18 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMabe65dc59251: [lib] Stop attempting recovery when client version unsupported.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

9 lines

socket/

socket.react.js

32 lines

Diff 39147

lib/reducers/keyserver-reducer.js

Loading...

lib/socket/socket.react.js

Loading...