Page MenuHomePhabricator
Differential D11647

[web] Extract a function that determines where to store notifs session
ClosedPublic
Actions

Authored by tomek on Apr 12 2024, 11:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 1:10 PM
Unknown Object (File)
Fri, Apr 26, 11:20 PM
Unknown Object (File)
Mon, Apr 22, 9:12 AM
Unknown Object (File)
Sun, Apr 21, 8:13 PM
Unknown Object (File)
Sun, Apr 21, 6:14 AM
Unknown Object (File)
Sat, Apr 20, 12:10 PM
Unknown Object (File)
Apr 18 2024, 10:39 AM
Unknown Object (File)
Apr 18 2024, 7:34 AM
View All 13 Files
Subscribers
ashoat

Details

Reviewers
kamil
varun
marcin
Commits
rCOMMe858ac54c903: [web] Extract a function that determines where to store notifs session
Summary

This function will be also used in a function that reassigns the session.

https://linear.app/comm/issue/ENG-7688/introduce-a-function-that-moves-a-notifs-session

Test Plan

Tested in combination with the next diffs: open the web app, login, send a message from another client - a notif should be displayed (without this stack we can only see a notif with a warning message). Also, verify that the reassignment actually occurs by adding some console logs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Apr 12 2024, 11:10 AM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 12 2024, 11:10 AM
tomek added a child revision: D11648: [web] Create a function that reassigns notifs session.Apr 12 2024, 11:13 AM
Harbormaster completed remote builds in B28191: Diff 39081.Apr 12 2024, 11:26 AM
tomek requested review of this revision.Apr 12 2024, 11:26 AM
marcin accepted this revision.Apr 15 2024, 12:18 AM
marcin added inline comments.
web/shared-worker/worker/worker-crypto.js
338 ↗(On Diff #39081)

Nit: Perhaps getNotifsPersistenceKeys would be better. This function clearly deals with notifs specific data.

This revision is now accepted and ready to land.Apr 15 2024, 12:18 AM
tomek updated this revision to Diff 39152.Apr 16 2024, 8:41 AM

Rename

Harbormaster completed remote builds in B28242: Diff 39152.Apr 16 2024, 8:57 AM
Closed by commit rCOMMe858ac54c903: [web] Extract a function that determines where to store notifs session (authored by tomek). · Explain WhyApr 18 2024, 7:53 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMe858ac54c903: [web] Extract a function that determines where to store notifs session.

Revision Contents
Changeset List

PathSize
web/
shared-worker/
worker/
45 lines

Diff 39152

View Options

web/shared-worker/worker/worker-crypto.js

Loading...