Page MenuHomePhabricator
Differential D11673

[native] check for null fid before adding to sqlite database
ClosedPublic
Actions

Authored by will on Wed, Apr 17, 7:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 4:30 PM
Unknown Object (File)
Sun, Apr 28, 5:13 PM
Unknown Object (File)
Sat, Apr 27, 9:18 AM
Unknown Object (File)
Fri, Apr 26, 11:16 PM
Unknown Object (File)
Fri, Apr 26, 1:49 PM
Unknown Object (File)
Fri, Apr 26, 1:41 PM
Unknown Object (File)
Wed, Apr 24, 10:52 AM
Unknown Object (File)
Thu, Apr 18, 6:25 PM
View All 11 Files
Subscribers
tomek

Details

Reviewers
ginsu
ashoat
marcin
atul
Commits
rCOMMc017019752b0: [native] check for null fid before adding to sqlite database
Summary

This checks for a null fid before dispatching a setSyncedMetadataEntryActionType (which always expects a string).

Test Plan

Went through new registration workflow on local dev environment and everything is working properly

Context: https://linear.app/comm/issue/ENG-7740/ios-simulator-app-crashing-a-brief-moment-after-completing-new#comment-11df0e2a

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Wed, Apr 17, 7:55 AM
Herald added a subscriber: tomek. · View Herald TranscriptWed, Apr 17, 7:55 AM
will added inline comments.Wed, Apr 17, 8:01 AM
native/account/registration/registration-server-call.js
247 ↗(On Diff #39175)

Originally had it as !!farcasterID but looks like it got removed in linting. Is it fine as is or should I do a more explicit guard like:
farcasterID !== null && farcasterID !== undefined

will published this revision for review.Wed, Apr 17, 8:03 AM
ashoat accepted this revision.Wed, Apr 17, 8:04 AM
This revision is now accepted and ready to land.Wed, Apr 17, 8:04 AM
This revision was landed with ongoing or failed builds.Wed, Apr 17, 8:07 AM
Closed by commit rCOMMc017019752b0: [native] check for null fid before adding to sqlite database (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMc017019752b0: [native] check for null fid before adding to sqlite database.
Harbormaster completed remote builds in B28260: Diff 39175.Wed, Apr 17, 8:12 AM

Revision Contents
Changeset List

PathSize
native/
account/
registration/
16 lines

Diff 39176

View Options

native/account/registration/registration-server-call.js

Loading...