Paths

Table of Contentst

Differential D11673

[native] check for null fid before adding to sqlite database
ClosedPublic
Actions

Authored by will on Apr 17 2024, 7:55 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 11:41 PM

	Unknown Object (File)
	Fri, Nov 8, 7:01 AM

	Unknown Object (File)
	Fri, Nov 8, 6:01 AM

	Unknown Object (File)
	Fri, Nov 8, 5:34 AM

	Unknown Object (File)
	Fri, Nov 8, 3:26 AM

	Unknown Object (File)
	Fri, Nov 8, 2:55 AM

	Unknown Object (File)
	Fri, Nov 8, 2:50 AM

	Unknown Object (File)
	Sun, Nov 3, 6:41 AM

View All 68 Files

Subscribers

Details

Reviewers

ginsu
ashoat
marcin
atul

Commits

rCOMMc017019752b0: [native] check for null fid before adding to sqlite database

Summary

This checks for a null fid before dispatching a setSyncedMetadataEntryActionType (which always expects a string).

Test Plan

Went through new registration workflow on local dev environment and everything is working properly

Context: https://linear.app/comm/issue/ENG-7740/ios-simulator-app-crashing-a-brief-moment-after-completing-new#comment-11df0e2a

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Apr 17 2024, 7:55 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 17 2024, 7:55 AM

will added inline comments.Apr 17 2024, 8:01 AM

native/account/registration/registration-server-call.js
247 ↗	(On Diff #39175)	Originally had it as `!!farcasterID` but looks like it got removed in linting. Is it fine as is or should I do a more explicit guard like: farcasterID !== null && farcasterID !== undefined

will published this revision for review.Apr 17 2024, 8:03 AM

ashoat accepted this revision.Apr 17 2024, 8:04 AM

This revision is now accepted and ready to land.Apr 17 2024, 8:04 AM

This revision was landed with ongoing or failed builds.Apr 17 2024, 8:07 AM

Closed by commit rCOMMc017019752b0: [native] check for null fid before adding to sqlite database (authored by will). · Explain Why

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMc017019752b0: [native] check for null fid before adding to sqlite database.

Harbormaster completed remote builds in B28260: Diff 39175.Apr 17 2024, 8:12 AM

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

registration-server-call.js

16 lines

Diff 39176

native/account/registration/registration-server-call.js

Loading...