Differential D11796

[identity] delete all token data on user account deletion
ClosedPublic
Actions

Authored by varun on Thu, Apr 25, 4:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 2, 6:25 AM

	Unknown Object (File)
	Tue, Apr 30, 8:03 PM

	Unknown Object (File)
	Tue, Apr 30, 11:23 AM

	Unknown Object (File)
	Sun, Apr 28, 5:13 PM

	Unknown Object (File)
	Thu, Apr 25, 6:30 PM

	Unknown Object (File)
	Thu, Apr 25, 6:26 PM

Subscribers

Details

Reviewers

Commits

rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion

Summary

new db method to get all tokens for a user and then delete them with BatchWriteItem. we use the comm-lib batch_write function for the delete requests.

Depends on D11795

Test Plan

signed in to a local account from web, native, and keyserver. then deleted my account from native. confirmed that there were no tokens in local ddb for my user ID

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Thu, Apr 25, 4:45 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Apr 25, 4:45 PM

Harbormaster completed remote builds in B28492: Diff 39522.Thu, Apr 25, 5:00 PM

varun requested review of this revision.Thu, Apr 25, 5:00 PM

bartek accepted this revision.Fri, Apr 26, 1:14 AM

bartek added inline comments.

services/identity/src/constants.rs
61–69 ↗	(On Diff #39522)	👍

This revision is now accepted and ready to land.Fri, Apr 26, 1:14 AM

Closed by commit rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion (authored by varun). · Explain WhyFri, Apr 26, 11:31 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

16 lines

3 lines

database/

138 lines

Diff 39572

services/identity/src/constants.rs

Loading...

services/identity/src/database.rs

Loading...

services/identity/src/database/token.rs

Loading...