Page MenuHomePhabricator
Differential D11796

[identity] delete all token data on user account deletion
ClosedPublic
Actions

Authored by varun on Apr 25 2024, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 9:29 PM
Unknown Object (File)
Feb 28 2025, 5:36 PM
Unknown Object (File)
Feb 28 2025, 5:35 PM
Unknown Object (File)
Feb 28 2025, 5:35 PM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Feb 6 2025, 11:45 AM
Unknown Object (File)
Jan 24 2025, 8:56 PM
Unknown Object (File)
Jan 24 2025, 8:56 PM
View All 63 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Commits
rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion
Summary

new db method to get all tokens for a user and then delete them with BatchWriteItem. we use the comm-lib batch_write function for the delete requests.

Depends on D11795

Test Plan

signed in to a local account from web, native, and keyserver. then deleted my account from native. confirmed that there were no tokens in local ddb for my user ID

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Apr 25 2024, 4:45 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 25 2024, 4:45 PM
Harbormaster completed remote builds in B28492: Diff 39522.Apr 25 2024, 5:00 PM
varun requested review of this revision.Apr 25 2024, 5:00 PM
bartek accepted this revision.Apr 26 2024, 1:14 AM
bartek added inline comments.
services/identity/src/constants.rs
61–69 ↗(On Diff #39522)

👍

This revision is now accepted and ready to land.Apr 26 2024, 1:14 AM
Closed by commit rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion (authored by varun). · Explain WhyApr 26 2024, 11:31 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMb08ab7a0087b: [identity] delete all token data on user account deletion.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
16 lines
3 lines
database/
138 lines

Diff 39572

View Options

services/identity/src/constants.rs

locals { locals {
lambda_error_subscribed_email = "error-reports@comm.app" lambda_error_subscribed_email = "error-reports@comm.app"
lambda_error_threshold = "2" lambda_error_threshold = "2"
identity_error_patterns = {
Search = { name = "Search", pattern = "Search Error" },
Sync = { name = "Sync", pattern = "Sync Error" },
Database = { name = "DB", pattern = "*DB Error" },
GrpcServices = { name = "GrpcServices", pattern = "gRPC Services Error" },
Siwe = { name = "Siwe", pattern = "SIWE Error" },
Tunnelbroker = { name = "Tunnelbroker", pattern = "Tunnelbroker Error" }
}
} }
resource "aws_sns_topic" "lambda_alarm_topic" { resource "aws_sns_topic" "lambda_alarm_topic" {
name = "lambda-error-alarm-topic" name = "lambda-error-alarm-topic"
} }
resource "aws_sns_topic_subscription" "email_subscription" { resource "aws_sns_topic_subscription" "email_subscription" {
topic_arn = aws_sns_topic.lambda_alarm_topic.arn topic_arn = aws_sns_topic.lambda_alarm_topic.arn
Show All 12 Linesresource "aws_cloudwatch_metric_alarm" "lambda_error_alarm" {
threshold = local.lambda_error_threshold threshold = local.lambda_error_threshold
alarm_description = "Alarm tracking search index lambda function failure" alarm_description = "Alarm tracking search index lambda function failure"
actions_enabled = true actions_enabled = true
alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn] alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn]
dimensions = { dimensions = {
FunctionName = module.shared.search_index_lambda.function_name FunctionName = module.shared.search_index_lambda.function_name
} }
} }
resource "aws_cloudwatch_log_metric_filter" "identity_error_filters" {
for_each = local.identity_error_patterns
name = "Identity${each.value.name}ErrorCount"
pattern = "{ $.level = \"ERROR\" && $.fields.errorType = \"${each.value.pattern}\" }"
log_group_name = "/ecs/identity-service-task-def"
metric_transformation {
name = "Identity${each.value.name}ErrorCount"
namespace = "IdentityServiceMetricFilters"
value = "1"
}
}
View Options

services/identity/src/database.rs

locals { locals {
lambda_error_subscribed_email = "error-reports@comm.app" lambda_error_subscribed_email = "error-reports@comm.app"
lambda_error_threshold = "2" lambda_error_threshold = "2"
identity_error_patterns = {
Search = { name = "Search", pattern = "Search Error" },
Sync = { name = "Sync", pattern = "Sync Error" },
Database = { name = "DB", pattern = "*DB Error" },
GrpcServices = { name = "GrpcServices", pattern = "gRPC Services Error" },
Siwe = { name = "Siwe", pattern = "SIWE Error" },
Tunnelbroker = { name = "Tunnelbroker", pattern = "Tunnelbroker Error" }
}
} }
resource "aws_sns_topic" "lambda_alarm_topic" { resource "aws_sns_topic" "lambda_alarm_topic" {
name = "lambda-error-alarm-topic" name = "lambda-error-alarm-topic"
} }
resource "aws_sns_topic_subscription" "email_subscription" { resource "aws_sns_topic_subscription" "email_subscription" {
topic_arn = aws_sns_topic.lambda_alarm_topic.arn topic_arn = aws_sns_topic.lambda_alarm_topic.arn
Show All 12 Linesresource "aws_cloudwatch_metric_alarm" "lambda_error_alarm" {
threshold = local.lambda_error_threshold threshold = local.lambda_error_threshold
alarm_description = "Alarm tracking search index lambda function failure" alarm_description = "Alarm tracking search index lambda function failure"
actions_enabled = true actions_enabled = true
alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn] alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn]
dimensions = { dimensions = {
FunctionName = module.shared.search_index_lambda.function_name FunctionName = module.shared.search_index_lambda.function_name
} }
} }
resource "aws_cloudwatch_log_metric_filter" "identity_error_filters" {
for_each = local.identity_error_patterns
name = "Identity${each.value.name}ErrorCount"
pattern = "{ $.level = \"ERROR\" && $.fields.errorType = \"${each.value.pattern}\" }"
log_group_name = "/ecs/identity-service-task-def"
metric_transformation {
name = "Identity${each.value.name}ErrorCount"
namespace = "IdentityServiceMetricFilters"
value = "1"
}
}
View Options

services/identity/src/database/token.rs

locals { locals {
lambda_error_subscribed_email = "error-reports@comm.app" lambda_error_subscribed_email = "error-reports@comm.app"
lambda_error_threshold = "2" lambda_error_threshold = "2"
identity_error_patterns = {
Search = { name = "Search", pattern = "Search Error" },
Sync = { name = "Sync", pattern = "Sync Error" },
Database = { name = "DB", pattern = "*DB Error" },
GrpcServices = { name = "GrpcServices", pattern = "gRPC Services Error" },
Siwe = { name = "Siwe", pattern = "SIWE Error" },
Tunnelbroker = { name = "Tunnelbroker", pattern = "Tunnelbroker Error" }
}
} }
resource "aws_sns_topic" "lambda_alarm_topic" { resource "aws_sns_topic" "lambda_alarm_topic" {
name = "lambda-error-alarm-topic" name = "lambda-error-alarm-topic"
} }
resource "aws_sns_topic_subscription" "email_subscription" { resource "aws_sns_topic_subscription" "email_subscription" {
topic_arn = aws_sns_topic.lambda_alarm_topic.arn topic_arn = aws_sns_topic.lambda_alarm_topic.arn
Show All 12 Linesresource "aws_cloudwatch_metric_alarm" "lambda_error_alarm" {
threshold = local.lambda_error_threshold threshold = local.lambda_error_threshold
alarm_description = "Alarm tracking search index lambda function failure" alarm_description = "Alarm tracking search index lambda function failure"
actions_enabled = true actions_enabled = true
alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn] alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn]
dimensions = { dimensions = {
FunctionName = module.shared.search_index_lambda.function_name FunctionName = module.shared.search_index_lambda.function_name
} }
} }
resource "aws_cloudwatch_log_metric_filter" "identity_error_filters" {
for_each = local.identity_error_patterns
name = "Identity${each.value.name}ErrorCount"
pattern = "{ $.level = \"ERROR\" && $.fields.errorType = \"${each.value.pattern}\" }"
log_group_name = "/ecs/identity-service-task-def"
metric_transformation {
name = "Identity${each.value.name}ErrorCount"
namespace = "IdentityServiceMetricFilters"
value = "1"
}
}