Page MenuHomePhabricator
Differential D11842

[lib/web] add test button to create initial peer list
ClosedPublic
Actions

Authored by kamil on Apr 30 2024, 6:53 AM.
Tags
None
Referenced Files
F3386439: D11842.diff
Fri, Nov 29, 4:45 AM
Unknown Object (File)
Mon, Nov 11, 8:48 PM
Unknown Object (File)
Mon, Nov 11, 8:46 PM
Unknown Object (File)
Mon, Nov 11, 7:38 AM
Unknown Object (File)
Sun, Nov 10, 11:41 AM
Unknown Object (File)
Fri, Nov 8, 7:18 PM
Unknown Object (File)
Fri, Nov 8, 6:10 PM
Unknown Object (File)
Fri, Nov 8, 5:40 PM
View All 67 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM43341ddfa482: [lib/web] add test button to create initial peer list
Summary

Before Identity launch, there isn't make any sense to run this migration, right now adding this only for testing purposes but the code can be reused.

Depends on D11841

Test Plan
  1. Test is store was properly populated
  2. Test is persisting works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Apr 30 2024, 6:53 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptApr 30 2024, 6:53 AM
kamil added a child revision: D11843: [native] add test button to create initial peer list.Apr 30 2024, 6:54 AM
Harbormaster completed remote builds in B28601: Diff 39694.Apr 30 2024, 7:10 AM
kamil published this revision for review.May 6 2024, 4:25 AM
kamil edited the summary of this revision. (Show Details)
kamil added 1 blocking reviewer(s): bartek.
ashoat mentioned this in D11843: [native] add test button to create initial peer list.May 6 2024, 11:43 AM
bartek accepted this revision.May 7 2024, 1:44 AM
bartek added inline comments.
lib/utils/device-list-utils.js
15 ↗(On Diff #39694)

Wondering if we should add a validator for RawDeviceList and assert it here

This revision is now accepted and ready to land.May 7 2024, 1:44 AM
kamil updated this revision to Diff 39881.May 7 2024, 4:17 AM

add assert & validator

Harbormaster completed remote builds in B28727: Diff 39881.May 7 2024, 4:36 AM
Closed by commit rCOMM43341ddfa482: [lib/web] add test button to create initial peer list (authored by kamil). · Explain WhyMay 7 2024, 4:55 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM43341ddfa482: [lib/web] add test button to create initial peer list.

Revision Contents
Changeset List

PathSize
lib/
selectors/
4 lines
types/
5 lines
utils/
26 lines
web/
settings/
34 lines

Diff 39887

View Options

lib/selectors/user-selectors.js

Loading...
View Options

lib/types/identity-service-types.js

Loading...
View Options

lib/utils/device-list-utils.js

Loading...
View Options

web/settings/account-settings.react.js

Loading...