Page MenuHomePhabricator
Differential D11938

[lib][keyserver] Move output entry validators to lib
ClosedPublic
Actions

Authored by inka on May 8 2024, 6:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 3 2025, 6:17 AM
Unknown Object (File)
Mar 3 2025, 6:17 AM
Unknown Object (File)
Feb 28 2025, 4:54 PM
Unknown Object (File)
Feb 28 2025, 4:54 PM
Unknown Object (File)
Jan 24 2025, 8:43 PM
Unknown Object (File)
Jan 24 2025, 8:42 PM
Unknown Object (File)
Jan 9 2025, 6:55 PM
Unknown Object (File)
Jan 9 2025, 6:49 PM
View All 62 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
bartek
Commits
rCOMMad058947ffea: [lib][keyserver] Move output entry validators to lib
Summary

issue: ENG-7818
keyserver/src/responders/responder-validators.test.js will be moved once all validator are moved ENG-8060

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
14 lines
responders/
43 lines
4 lines
lib/
types/
validators/
59 lines

Diff 39971

View Options

keyserver/src/endpoints.js

locals { locals {
lambda_error_subscribed_email = "error-reports@comm.app" lambda_error_subscribed_email = "error-reports@comm.app"
lambda_error_threshold = "2" lambda_error_threshold = "2"
identity_error_patterns = {
Search = { name = "Search", pattern = "Search Error" },
Sync = { name = "Sync", pattern = "Sync Error" },
Database = { name = "DB", pattern = "*DB Error" },
GrpcServices = { name = "GrpcServices", pattern = "gRPC Services Error" },
Siwe = { name = "Siwe", pattern = "SIWE Error" },
Tunnelbroker = { name = "Tunnelbroker", pattern = "Tunnelbroker Error" }
}
} }
resource "aws_sns_topic" "lambda_alarm_topic" { resource "aws_sns_topic" "lambda_alarm_topic" {
name = "lambda-error-alarm-topic" name = "lambda-error-alarm-topic"
} }
resource "aws_sns_topic_subscription" "email_subscription" { resource "aws_sns_topic_subscription" "email_subscription" {
topic_arn = aws_sns_topic.lambda_alarm_topic.arn topic_arn = aws_sns_topic.lambda_alarm_topic.arn
Show All 12 Linesresource "aws_cloudwatch_metric_alarm" "lambda_error_alarm" {
threshold = local.lambda_error_threshold threshold = local.lambda_error_threshold
alarm_description = "Alarm tracking search index lambda function failure" alarm_description = "Alarm tracking search index lambda function failure"
actions_enabled = true actions_enabled = true
alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn] alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn]
dimensions = { dimensions = {
FunctionName = module.shared.search_index_lambda.function_name FunctionName = module.shared.search_index_lambda.function_name
} }
} }
resource "aws_cloudwatch_log_metric_filter" "identity_error_filters" {
for_each = local.identity_error_patterns
name = "Identity${each.value.name}ErrorCount"
pattern = "{ $.level = \"ERROR\" && $.fields.errorType = \"${each.value.pattern}\" }"
log_group_name = "/ecs/identity-service-task-def"
metric_transformation {
name = "Identity${each.value.name}ErrorCount"
namespace = "IdentityServiceMetricFilters"
value = "1"
}
}
View Options

keyserver/src/responders/entry-responders.js

locals { locals {
lambda_error_subscribed_email = "error-reports@comm.app" lambda_error_subscribed_email = "error-reports@comm.app"
lambda_error_threshold = "2" lambda_error_threshold = "2"
identity_error_patterns = {
Search = { name = "Search", pattern = "Search Error" },
Sync = { name = "Sync", pattern = "Sync Error" },
Database = { name = "DB", pattern = "*DB Error" },
GrpcServices = { name = "GrpcServices", pattern = "gRPC Services Error" },
Siwe = { name = "Siwe", pattern = "SIWE Error" },
Tunnelbroker = { name = "Tunnelbroker", pattern = "Tunnelbroker Error" }
}
} }
resource "aws_sns_topic" "lambda_alarm_topic" { resource "aws_sns_topic" "lambda_alarm_topic" {
name = "lambda-error-alarm-topic" name = "lambda-error-alarm-topic"
} }
resource "aws_sns_topic_subscription" "email_subscription" { resource "aws_sns_topic_subscription" "email_subscription" {
topic_arn = aws_sns_topic.lambda_alarm_topic.arn topic_arn = aws_sns_topic.lambda_alarm_topic.arn
Show All 12 Linesresource "aws_cloudwatch_metric_alarm" "lambda_error_alarm" {
threshold = local.lambda_error_threshold threshold = local.lambda_error_threshold
alarm_description = "Alarm tracking search index lambda function failure" alarm_description = "Alarm tracking search index lambda function failure"
actions_enabled = true actions_enabled = true
alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn] alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn]
dimensions = { dimensions = {
FunctionName = module.shared.search_index_lambda.function_name FunctionName = module.shared.search_index_lambda.function_name
} }
} }
resource "aws_cloudwatch_log_metric_filter" "identity_error_filters" {
for_each = local.identity_error_patterns
name = "Identity${each.value.name}ErrorCount"
pattern = "{ $.level = \"ERROR\" && $.fields.errorType = \"${each.value.pattern}\" }"
log_group_name = "/ecs/identity-service-task-def"
metric_transformation {
name = "Identity${each.value.name}ErrorCount"
namespace = "IdentityServiceMetricFilters"
value = "1"
}
}
View Options

keyserver/src/responders/responder-validators.test.js

locals { locals {
lambda_error_subscribed_email = "error-reports@comm.app" lambda_error_subscribed_email = "error-reports@comm.app"
lambda_error_threshold = "2" lambda_error_threshold = "2"
identity_error_patterns = {
Search = { name = "Search", pattern = "Search Error" },
Sync = { name = "Sync", pattern = "Sync Error" },
Database = { name = "DB", pattern = "*DB Error" },
GrpcServices = { name = "GrpcServices", pattern = "gRPC Services Error" },
Siwe = { name = "Siwe", pattern = "SIWE Error" },
Tunnelbroker = { name = "Tunnelbroker", pattern = "Tunnelbroker Error" }
}
} }
resource "aws_sns_topic" "lambda_alarm_topic" { resource "aws_sns_topic" "lambda_alarm_topic" {
name = "lambda-error-alarm-topic" name = "lambda-error-alarm-topic"
} }
resource "aws_sns_topic_subscription" "email_subscription" { resource "aws_sns_topic_subscription" "email_subscription" {
topic_arn = aws_sns_topic.lambda_alarm_topic.arn topic_arn = aws_sns_topic.lambda_alarm_topic.arn
Show All 12 Linesresource "aws_cloudwatch_metric_alarm" "lambda_error_alarm" {
threshold = local.lambda_error_threshold threshold = local.lambda_error_threshold
alarm_description = "Alarm tracking search index lambda function failure" alarm_description = "Alarm tracking search index lambda function failure"
actions_enabled = true actions_enabled = true
alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn] alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn]
dimensions = { dimensions = {
FunctionName = module.shared.search_index_lambda.function_name FunctionName = module.shared.search_index_lambda.function_name
} }
} }
resource "aws_cloudwatch_log_metric_filter" "identity_error_filters" {
for_each = local.identity_error_patterns
name = "Identity${each.value.name}ErrorCount"
pattern = "{ $.level = \"ERROR\" && $.fields.errorType = \"${each.value.pattern}\" }"
log_group_name = "/ecs/identity-service-task-def"
metric_transformation {
name = "Identity${each.value.name}ErrorCount"
namespace = "IdentityServiceMetricFilters"
value = "1"
}
}
View Options

lib/types/validators/entry-validators.js

locals { locals {
lambda_error_subscribed_email = "error-reports@comm.app" lambda_error_subscribed_email = "error-reports@comm.app"
lambda_error_threshold = "2" lambda_error_threshold = "2"
identity_error_patterns = {
Search = { name = "Search", pattern = "Search Error" },
Sync = { name = "Sync", pattern = "Sync Error" },
Database = { name = "DB", pattern = "*DB Error" },
GrpcServices = { name = "GrpcServices", pattern = "gRPC Services Error" },
Siwe = { name = "Siwe", pattern = "SIWE Error" },
Tunnelbroker = { name = "Tunnelbroker", pattern = "Tunnelbroker Error" }
}
} }
resource "aws_sns_topic" "lambda_alarm_topic" { resource "aws_sns_topic" "lambda_alarm_topic" {
name = "lambda-error-alarm-topic" name = "lambda-error-alarm-topic"
} }
resource "aws_sns_topic_subscription" "email_subscription" { resource "aws_sns_topic_subscription" "email_subscription" {
topic_arn = aws_sns_topic.lambda_alarm_topic.arn topic_arn = aws_sns_topic.lambda_alarm_topic.arn
Show All 12 Linesresource "aws_cloudwatch_metric_alarm" "lambda_error_alarm" {
threshold = local.lambda_error_threshold threshold = local.lambda_error_threshold
alarm_description = "Alarm tracking search index lambda function failure" alarm_description = "Alarm tracking search index lambda function failure"
actions_enabled = true actions_enabled = true
alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn] alarm_actions = [aws_sns_topic.lambda_alarm_topic.arn]
dimensions = { dimensions = {
FunctionName = module.shared.search_index_lambda.function_name FunctionName = module.shared.search_index_lambda.function_name
} }
} }
resource "aws_cloudwatch_log_metric_filter" "identity_error_filters" {
for_each = local.identity_error_patterns
name = "Identity${each.value.name}ErrorCount"
pattern = "{ $.level = \"ERROR\" && $.fields.errorType = \"${each.value.pattern}\" }"
log_group_name = "/ecs/identity-service-task-def"
metric_transformation {
name = "Identity${each.value.name}ErrorCount"
namespace = "IdentityServiceMetricFilters"
value = "1"
}
}