Page MenuHomePhabricator

[lib][keyserver] Move user and version validators to lib
ClosedPublic

Authored by inka on Wed, May 8, 7:32 AM.
Tags
None
Referenced Files
F1792988: D11945.id39971.diff
Sun, May 19, 2:04 PM
F1791247: D11945.id39937.diff
Sun, May 19, 12:03 PM
Unknown Object (File)
Sat, May 18, 5:16 PM
Unknown Object (File)
Sat, May 18, 3:22 PM
Unknown Object (File)
Sat, May 18, 12:26 PM
Unknown Object (File)
Sat, May 18, 11:10 AM
Unknown Object (File)
Fri, May 17, 3:43 PM
Unknown Object (File)
Fri, May 17, 3:43 PM
Subscribers

Details

Summary

issue: ENG-7818
Move output validators to lib

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Wed, May 8, 7:48 AM
tomek added inline comments.
lib/types/validators/user-validators.js
13 ↗(On Diff #39935)

Don't we have to use a file extension?

This revision is now accepted and ready to land.Wed, May 8, 10:06 AM
lib/types/validators/user-validators.js
13 ↗(On Diff #39935)

Unfortunately the ESLint rule does not enforce type imports. ESLint is mostly not able to parse Flow syntax, so we have to run everything through @babel/eslint-parser, which strips the Flow syntax. I've noticed in some cases (eg. Prettier) it is able to pass through everything including the Flow syntax, but in most cases it gets stripped

We should make sure to include the file extensions for consistency, but it does not affect much (except my ability to open files in vim by putting my cursor over the filename)