Page MenuHomePhabricator

[lib][native] Add nonceTimestamp to SIWEResult
ClosedPublic

Authored by ashoat on May 12 2024, 7:30 PM.
Tags
None
Referenced Files
F2835236: D12005.diff
Sat, Sep 28, 1:17 PM
Unknown Object (File)
Sat, Sep 14, 10:28 PM
Unknown Object (File)
Tue, Sep 10, 11:55 PM
Unknown Object (File)
Fri, Sep 6, 6:14 PM
Unknown Object (File)
Thu, Aug 29, 6:36 PM
Unknown Object (File)
Aug 28 2024, 11:11 PM
Unknown Object (File)
Aug 28 2024, 4:58 PM
Unknown Object (File)
Aug 8 2024, 10:51 AM
Subscribers

Details

Summary

SIWEResult is a type only used on native. It's what SIWEPanel returns after a successful SIWE.

For ENG-7665, we want to know when the nonce was generated in order to determine whether to allow the user to use the cached SIWE result.

Would normally put @varun on the review here, but going to ask @inka instead because he is out.

Test Plan

I tested (or will test) this diff stack as follows:

  1. Be in a multi-keyserver environment, testing SIWE with iOS simulator
  2. Do a SIWE and then wait 2 minutes to let the nonce expire in the following screens:
    • FullscreenSIWEPanel for an account that doesn't exist yet when the new registration flow is disabled
    • FullscreenSIWEPanel for an account that doesn't exist yet when the new registration flow is enabled
    • FullscreenSIWEPanel for an account that does exist
    • New registration flow for an account that doesn't exist yet (RegistrationTerms)
    • New registration flow for an account that does exist (ExistingEthereumAccount)
  3. Make sure there are no duplicate Alerts, that in all cases an Alert is shown, and that the "back" action activates when the user confirms the Alert

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable