Paths

Table of Contentst

Differential D12028

[lib] Remove request_access
ClosedPublic
Actions

Authored by inka on May 14 2024, 5:23 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 5, 11:59 PM

	Unknown Object (File)
	Thu, Aug 29, 5:22 AM

	Unknown Object (File)
	Wed, Aug 14, 9:33 PM

	Unknown Object (File)
	Wed, Aug 14, 6:43 PM

	Unknown Object (File)
	Aug 1 2024, 12:17 AM

	Unknown Object (File)
	Aug 1 2024, 12:17 AM

	Unknown Object (File)
	Aug 1 2024, 12:16 AM

	Unknown Object (File)
	Aug 1 2024, 12:16 AM

View All 33 Files

Subscribers

ashoat

Details

Reviewers

tomek
kamil
bartek

Commits

rCOMM1a2b808c4a37: [lib] Remove request_access

Summary

This was not used in any way - there is no request_access endpoint on the keyserver and this string is not uned anywhere else in the app

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 14 2024, 5:23 AM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 14 2024, 5:23 AM

inka added a parent revision: D11984: [lib] Add extractUserIDsFromPayload.May 14 2024, 5:29 AM

inka added a child revision: D12029: [lib][keyserver] Move upload output validators to lib.

Harbormaster completed remote builds in B28894: Diff 40156.May 14 2024, 5:38 AM

inka requested review of this revision.May 14 2024, 5:38 AM

This is a leftover from a feature that we had https://github.com/CommE2E/comm/commit/d967a4423104140388fb8227787f676abf319dd0

This revision is now accepted and ready to land.May 14 2024, 7:59 AM

Closed by commit rCOMM1a2b808c4a37: [lib] Remove request_access (authored by inka). · Explain WhyMay 15 2024, 6:22 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM1a2b808c4a37: [lib] Remove request_access.

Revision Contents
Changeset List

Path

Size

lib/

types/

endpoints.js

1 line

Diff 40214

View Options

[lib] Remove request_accessClosedPublicActions