Page MenuHomePhabricator
Differential D12058

[native] fix casing of error alert details
ClosedPublic
Actions

Authored by ginsu on May 15 2024, 11:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 12:12 PM
Unknown Object (File)
Sun, Mar 30, 3:48 PM
Unknown Object (File)
Sun, Mar 30, 1:49 PM
Unknown Object (File)
Sun, Mar 30, 5:42 AM
Unknown Object (File)
Sun, Mar 30, 4:46 AM
Unknown Object (File)
Sat, Mar 29, 2:42 PM
Unknown Object (File)
Wed, Mar 26, 9:06 PM
Unknown Object (File)
Feb 26 2025, 3:26 AM
View All 78 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
will
Commits
rCOMM5752a75f79be: [native] fix casing of error alert details
Summary

Rename diff. This should address an inline comment from D11873

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
eng-7378 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 15 2024, 11:13 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 15 2024, 11:13 AM
ginsu edited the summary of this revision. (Show Details)May 15 2024, 11:14 AM
ginsu added reviewers: ashoat, will.
ginsu mentioned this in D11873: [native] introduce getFarcasterAccountAlreadyLinkedAlertDetails.
Harbormaster completed remote builds in B28955: Diff 40239.May 15 2024, 11:30 AM
ginsu requested review of this revision.May 15 2024, 11:30 AM
will accepted this revision.May 15 2024, 12:06 PM
This revision is now accepted and ready to land.May 15 2024, 12:06 PM
ginsu updated this revision to Diff 40254.May 15 2024, 12:15 PM

rebase before landing

This revision was landed with ongoing or failed builds.May 15 2024, 12:15 PM
Closed by commit rCOMM5752a75f79be: [native] fix casing of error alert details (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5752a75f79be: [native] fix casing of error alert details.
Harbormaster failed remote builds in B28959: Diff 40254!May 15 2024, 12:29 PM
ginsu mentioned this in D12059: [native] fix error alert detail casing in AddKeyserver.May 15 2024, 12:36 PM
ginsu mentioned this in rCOMMbc5ae1bce912: [native] fix error alert detail casing in AddKeyserver.May 15 2024, 1:49 PM

Revision Contents
Changeset List

Diff 40239

View Options

native/account/fullscreen-siwe-panel.react.js

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines infoValidator: tShape<ThreadJoinUpdateInfo>({
type: tNumber(updateTypes.JOIN_THREAD), type: tNumber(updateTypes.JOIN_THREAD),
id: t.String, id: t.String,
time: t.Number, time: t.Number,
threadInfo: mixedRawThreadInfoValidator, threadInfo: mixedRawThreadInfoValidator,
rawMessageInfos: t.list(rawMessageInfoValidator), rawMessageInfos: t.list(rawMessageInfoValidator),
truncationStatus: messageTruncationStatusValidator, truncationStatus: messageTruncationStatusValidator,
rawEntryInfos: t.list(rawEntryInfoValidator), rawEntryInfos: t.list(rawEntryInfoValidator),
}), }),
getUpdatedThreadInfo: (update: ThreadJoinUpdateInfo) => update.threadInfo,
}); });
View Options

native/account/legacy-register-panel.react.js

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines infoValidator: tShape<ThreadJoinUpdateInfo>({
type: tNumber(updateTypes.JOIN_THREAD), type: tNumber(updateTypes.JOIN_THREAD),
id: t.String, id: t.String,
time: t.Number, time: t.Number,
threadInfo: mixedRawThreadInfoValidator, threadInfo: mixedRawThreadInfoValidator,
rawMessageInfos: t.list(rawMessageInfoValidator), rawMessageInfos: t.list(rawMessageInfoValidator),
truncationStatus: messageTruncationStatusValidator, truncationStatus: messageTruncationStatusValidator,
rawEntryInfos: t.list(rawEntryInfoValidator), rawEntryInfos: t.list(rawEntryInfoValidator),
}), }),
getUpdatedThreadInfo: (update: ThreadJoinUpdateInfo) => update.threadInfo,
}); });
View Options

native/account/log-in-panel.react.js

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines infoValidator: tShape<ThreadJoinUpdateInfo>({
type: tNumber(updateTypes.JOIN_THREAD), type: tNumber(updateTypes.JOIN_THREAD),
id: t.String, id: t.String,
time: t.Number, time: t.Number,
threadInfo: mixedRawThreadInfoValidator, threadInfo: mixedRawThreadInfoValidator,
rawMessageInfos: t.list(rawMessageInfoValidator), rawMessageInfos: t.list(rawMessageInfoValidator),
truncationStatus: messageTruncationStatusValidator, truncationStatus: messageTruncationStatusValidator,
rawEntryInfos: t.list(rawEntryInfoValidator), rawEntryInfos: t.list(rawEntryInfoValidator),
}), }),
getUpdatedThreadInfo: (update: ThreadJoinUpdateInfo) => update.threadInfo,
}); });
View Options

native/account/registration/existing-ethereum-account.react.js

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines infoValidator: tShape<ThreadJoinUpdateInfo>({
type: tNumber(updateTypes.JOIN_THREAD), type: tNumber(updateTypes.JOIN_THREAD),
id: t.String, id: t.String,
time: t.Number, time: t.Number,
threadInfo: mixedRawThreadInfoValidator, threadInfo: mixedRawThreadInfoValidator,
rawMessageInfos: t.list(rawMessageInfoValidator), rawMessageInfos: t.list(rawMessageInfoValidator),
truncationStatus: messageTruncationStatusValidator, truncationStatus: messageTruncationStatusValidator,
rawEntryInfos: t.list(rawEntryInfoValidator), rawEntryInfos: t.list(rawEntryInfoValidator),
}), }),
getUpdatedThreadInfo: (update: ThreadJoinUpdateInfo) => update.threadInfo,
}); });
View Options

native/account/registration/registration-server-call.js

Loading...
View Options

native/account/siwe-panel.react.js

Loading...
View Options

native/chat/compose-subchannel.react.js

Loading...
View Options

native/chat/relationship-prompt.react.js

Loading...
View Options

native/chat/settings/add-users-modal.react.js

Loading...
View Options

native/chat/settings/color-selector-modal.react.js

Loading...
View Options

native/chat/settings/delete-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-description.react.js

Loading...
View Options

native/chat/settings/thread-settings-edit-relationship.react.js

Loading...
View Options

native/chat/settings/thread-settings-leave-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

native/chat/settings/thread-settings-promote-sidebar.react.js

Loading...
View Options

native/components/version-supported.react.js

Loading...
View Options

native/profile/default-notifications-preferences.react.js

Loading...
View Options

native/profile/edit-password.react.js

Loading...
View Options

native/profile/farcaster-account-settings.react.js

Loading...
View Options

native/profile/relationship-list-item.react.js

Loading...
View Options

native/profile/relationship-list.react.js

Loading...
View Options

native/profile/user-relationship-tooltip-modal.react.js

Loading...
View Options

native/redux/redux-setup.js

Loading...
View Options

native/user-profile/user-profile-relationship-button.react.js

Loading...
View Options

native/utils/alert-messages.js

Loading...
View Options

native/utils/farcaster-utils.js

Loading...