Page MenuHomePhabricator
Differential D12066

[native] Pass initialDeviceList param through JSI
ClosedPublic
Actions

Authored by bartek on May 15 2024, 11:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 10:07 PM
Unknown Object (File)
Thu, Mar 13, 7:13 AM
Unknown Object (File)
Feb 21 2025, 6:55 AM
Unknown Object (File)
Feb 21 2025, 6:55 AM
Unknown Object (File)
Feb 21 2025, 6:55 AM
Unknown Object (File)
Feb 21 2025, 6:55 AM
Unknown Object (File)
Jan 28 2025, 9:22 PM
Unknown Object (File)
Jan 24 2025, 8:13 PM
View All 59 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
will
Commits
rCOMM9e1e6936780e: [native] Pass initialDeviceList param through JSI
Summary

Exposed the initialDeviceList argument Rust -> JSI -> CommRustModule. Moved the "empty string" stub to JS callsites

Depends on D12017

Test Plan

Native compiles. Confirmed that passing arbitratry values from JS makes Identity Service receive them when user is registered.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
6 lines
10 lines
_generated/
identity-service/
2 lines
native_rust_library/
src/
identity/
16 lines
2 lines
schema/
2 lines

Diff 40335

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

  • This file was added.
#pragma once
#ifndef SQLITE_ENABLE_SESSION
#define SQLITE_ENABLE_SESSION
#endif
#include <sqlite3.h>
#include <functional>
#include <vector>
namespace comm {
class SQLiteConnectionManager {
protected:
sqlite3 *dbConnection;
static void handleSQLiteError(
int errorCode,
const std::string &errorMessagePrefix,
int expectedResultCode = SQLITE_OK);
void closeConnectionInternal();
public:
SQLiteConnectionManager();
sqlite3 *getConnection();
virtual void initializeConnection(
std::string sqliteFilePath,
std::function<void(sqlite3 *)> on_db_open_callback);
virtual void closeConnection();
virtual ~SQLiteConnectionManager();
};
} // namespace comm
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

  • This file was added.
#pragma once
#ifndef SQLITE_ENABLE_SESSION
#define SQLITE_ENABLE_SESSION
#endif
#include <sqlite3.h>
#include <functional>
#include <vector>
namespace comm {
class SQLiteConnectionManager {
protected:
sqlite3 *dbConnection;
static void handleSQLiteError(
int errorCode,
const std::string &errorMessagePrefix,
int expectedResultCode = SQLITE_OK);
void closeConnectionInternal();
public:
SQLiteConnectionManager();
sqlite3 *getConnection();
virtual void initializeConnection(
std::string sqliteFilePath,
std::function<void(sqlite3 *)> on_db_open_callback);
virtual void closeConnection();
virtual ~SQLiteConnectionManager();
};
} // namespace comm
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

  • This file was added.
#pragma once
#ifndef SQLITE_ENABLE_SESSION
#define SQLITE_ENABLE_SESSION
#endif
#include <sqlite3.h>
#include <functional>
#include <vector>
namespace comm {
class SQLiteConnectionManager {
protected:
sqlite3 *dbConnection;
static void handleSQLiteError(
int errorCode,
const std::string &errorMessagePrefix,
int expectedResultCode = SQLITE_OK);
void closeConnectionInternal();
public:
SQLiteConnectionManager();
sqlite3 *getConnection();
virtual void initializeConnection(
std::string sqliteFilePath,
std::function<void(sqlite3 *)> on_db_open_callback);
virtual void closeConnection();
virtual ~SQLiteConnectionManager();
};
} // namespace comm
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

  • This file was added.
#pragma once
#ifndef SQLITE_ENABLE_SESSION
#define SQLITE_ENABLE_SESSION
#endif
#include <sqlite3.h>
#include <functional>
#include <vector>
namespace comm {
class SQLiteConnectionManager {
protected:
sqlite3 *dbConnection;
static void handleSQLiteError(
int errorCode,
const std::string &errorMessagePrefix,
int expectedResultCode = SQLITE_OK);
void closeConnectionInternal();
public:
SQLiteConnectionManager();
sqlite3 *getConnection();
virtual void initializeConnection(
std::string sqliteFilePath,
std::function<void(sqlite3 *)> on_db_open_callback);
virtual void closeConnection();
virtual ~SQLiteConnectionManager();
};
} // namespace comm
View Options

native/identity-service/identity-service-context-provider.react.js

  • This file was added.
#pragma once
#ifndef SQLITE_ENABLE_SESSION
#define SQLITE_ENABLE_SESSION
#endif
#include <sqlite3.h>
#include <functional>
#include <vector>
namespace comm {
class SQLiteConnectionManager {
protected:
sqlite3 *dbConnection;
static void handleSQLiteError(
int errorCode,
const std::string &errorMessagePrefix,
int expectedResultCode = SQLITE_OK);
void closeConnectionInternal();
public:
SQLiteConnectionManager();
sqlite3 *getConnection();
virtual void initializeConnection(
std::string sqliteFilePath,
std::function<void(sqlite3 *)> on_db_open_callback);
virtual void closeConnection();
virtual ~SQLiteConnectionManager();
};
} // namespace comm
View Options

native/native_rust_library/src/identity/registration.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...