Paths

Table of Contentst

Differential D12066

[native] Pass initialDeviceList param through JSI
ClosedPublic
Actions

Authored by bartek on May 16 2024, 6:56 AM.

Details

Reviewers

kamil
will

Commits

rCOMM9e1e6936780e: [native] Pass initialDeviceList param through JSI

Summary

Exposed the initialDeviceList argument Rust -> JSI -> CommRustModule. Moved the "empty string" stub to JS callsites

Depends on D12017

Test Plan

Native compiles. Confirmed that passing arbitratry values from JS makes Identity Service receive them when user is registered.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 16 2024, 6:56 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 16 2024, 6:56 AM

bartek added a child revision: D12067: [native] Create initial device list during registration.May 16 2024, 7:00 AM

Harbormaster completed remote builds in B28973: Diff 40276.May 16 2024, 7:12 AM

bartek published this revision for review.May 16 2024, 7:29 AM

kamil accepted this revision.May 16 2024, 8:52 AM

This revision is now accepted and ready to land.May 16 2024, 8:52 AM

Closed by commit rCOMM9e1e6936780e: [native] Pass initialDeviceList param through JSI. · Explain WhyMay 17 2024, 2:16 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM9e1e6936780e: [native] Pass initialDeviceList param through JSI.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

6 lines

CommRustModule.cpp

10 lines

_generated/

rustJSI-generated.cpp

rustJSI.h

identity-service/

identity-service-context-provider.react.js

2 lines

native_rust_library/

src/

identity/

registration.rs

16 lines

lib.rs

2 lines

schema/

CommRustModuleSchema.js

2 lines

Diff 40335

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI.h

View Options

native/identity-service/identity-service-context-provider.react.js

View Options

native/native_rust_library/src/identity/registration.rs

View Options

native/native_rust_library/src/lib.rs

View Options

native/schema/CommRustModuleSchema.js

[native] Pass initialDeviceList param through JSIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40335

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/identity-service/identity-service-context-provider.react.js

native/native_rust_library/src/identity/registration.rs

native/native_rust_library/src/lib.rs

native/schema/CommRustModuleSchema.js

[native] Pass initialDeviceList param through JSI
ClosedPublic
Actions

Revision Contents
Changeset List