[web] Retrieve username on secondary device login
ClosedPublic
Actions

Authored by bartek on May 20 2024, 11:04 PM.

Details

Reviewers

inka
varun
will

Commits

rCOMMd07ef861c6db: [web] Retrieve username on secondary device login

Summary

Addresses ENG-7215 on web.
Now we have username in RCPs response, so we can simply pass it to identityAuthResult, replacing the empty string placeholder.

Depends on D12134.

Test Plan

Console.log the identityAuthResult in the uploadKeysForRegisteredDeviceAndLogIn() and confirmed the username was there during QR login.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 20 2024, 11:04 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 20 2024, 11:04 PM

Harbormaster completed remote builds in B29078: Diff 40427.May 20 2024, 11:19 PM

bartek published this revision for review.May 21 2024, 12:25 AM

varun accepted this revision.May 21 2024, 2:00 AM

This revision is now accepted and ready to land.May 21 2024, 2:00 AM

On web, retrieve username consistently everywhere. Rebase before landing

Harbormaster completed remote builds in B29151: Diff 40521.May 22 2024, 3:10 AM

Closed by commit rCOMMd07ef861c6db: [web] Retrieve username on secondary device login (authored by bartek). · Explain WhyMay 23 2024, 11:28 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd07ef861c6db: [web] Retrieve username on secondary device login.

Revision Contents
Changeset List

Path

Size

web/

grpc/

identity-service-client-wrapper.js

13 lines

Diff 40607

View Options

web/grpc/identity-service-client-wrapper.js

[web] Retrieve username on secondary device loginClosedPublicActions