Page MenuHomePhabricator

[reports] Verify CSAT if present
ClosedPublic

Authored by bartek on Jun 17 2024, 3:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 1:38 PM
Unknown Object (File)
Tue, Oct 29, 8:05 PM
Unknown Object (File)
Fri, Oct 25, 12:26 PM
Unknown Object (File)
Mon, Oct 21, 10:55 PM
Unknown Object (File)
Sun, Oct 20, 12:16 AM
Unknown Object (File)
Wed, Oct 16, 1:47 AM
Unknown Object (File)
Sun, Oct 13, 5:37 AM
Unknown Object (File)
Sun, Oct 13, 5:37 AM
Subscribers

Details

Summary

CSAT for uploading reports is optional. If it's present, reporting user ID can be retrieved from it.
It's also used for Blob service requests (report upload). If it's not present, a service-to-service token is retrieved.

This diff handles the case, when requesting UserIdentity (CSAT) is present, but Identity verification failed.
In this case, we need service-to-service token, the same as for non-existing credential.

Depends on D12416

Test Plan

Tested locally and on staging. Uploaded large (> 400kB) report with valid and invalid credentials.
Both uploads succeeded. Looking at Blob service logs (level=trace), noted that:

  • the former request used UserIdentity credential,
  • the latter request used ServicesToken credential.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable