[web] mark otks as published before attempting to upload keys to identity
ClosedPublic
Actions

Authored by varun on Jun 18 2024, 10:51 AM.

Details

Reviewers

kamil
marcin

Commits

rCOMMeaef1fac6184: [web] mark otks as published before attempting to upload keys to identity

Summary

we already mark the otks as published before calling uploadOneTimeKeys, but we need to mark them as published before calling uploadKeysForRegisteredDeviceAndLogIn

Depends on D12466

note that we don't upload OTKs on normal login anymore

Test Plan

disabled the uploadKeysForRegisteredDeviceAndLogIn RPC and confirmed that the OTKs were still marked as published

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 18 2024, 10:51 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 18 2024, 10:51 AM

Harbormaster completed remote builds in B29754: Diff 41461.Jun 18 2024, 11:07 AM

varun requested review of this revision.Jun 18 2024, 11:07 AM

This looks good to me, but to be honest I'm not very familiar with this code, so would be great if either @kamil or @marcin could take a look as well

marcin accepted this revision.Jun 19 2024, 6:09 AM

This revision is now accepted and ready to land.Jun 19 2024, 6:09 AM

Closed by commit rCOMMeaef1fac6184: [web] mark otks as published before attempting to upload keys to identity (authored by varun). · Explain WhyJun 19 2024, 6:39 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMeaef1fac6184: [web] mark otks as published before attempting to upload keys to identity.

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

worker/

worker-crypto.js

3 lines

Diff 41487

View Options

web/shared-worker/worker/worker-crypto.js

[web] mark otks as published before attempting to upload keys to identityClosedPublicActions