Page MenuHomePhabricator

[web] mark otks as published before attempting to upload keys to identity
ClosedPublic

Authored by varun on Jun 18 2024, 10:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 10:58 AM
Unknown Object (File)
Thu, Jan 23, 10:58 AM
Unknown Object (File)
Thu, Jan 23, 10:57 AM
Unknown Object (File)
Thu, Jan 23, 10:43 AM
Unknown Object (File)
Wed, Jan 15, 4:19 AM
Unknown Object (File)
Dec 18 2024, 6:48 AM
Unknown Object (File)
Dec 18 2024, 6:48 AM
Unknown Object (File)
Dec 18 2024, 6:48 AM
Subscribers

Details

Summary

we already mark the otks as published before calling uploadOneTimeKeys, but we need to mark them as published before calling uploadKeysForRegisteredDeviceAndLogIn

Depends on D12466

note that we don't upload OTKs on normal login anymore

Test Plan

disabled the uploadKeysForRegisteredDeviceAndLogIn RPC and confirmed that the OTKs were still marked as published

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat edited reviewers, added: kamil, marcin; removed: ashoat.
ashoat added subscribers: kamil, marcin.

This looks good to me, but to be honest I'm not very familiar with this code, so would be great if either @kamil or @marcin could take a look as well

This revision is now accepted and ready to land.Jun 19 2024, 6:09 AM