Page MenuHomePhabricator

[lib] remove updateThreadStoreThreadInfos util function
ClosedPublic

Authored by ginsu on Jun 19 2024, 5:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 12, 10:21 AM
Unknown Object (File)
Thu, Sep 12, 10:21 AM
Unknown Object (File)
Thu, Sep 12, 10:21 AM
Unknown Object (File)
Thu, Sep 12, 10:21 AM
Unknown Object (File)
Thu, Sep 12, 10:21 AM
Unknown Object (File)
Aug 29 2024, 1:22 AM
Unknown Object (File)
Aug 10 2024, 7:00 AM
Unknown Object (File)
Aug 10 2024, 7:00 AM
Subscribers

Details

Summary

With migration 77, I had a huge misunderstanding about the new migration approach. I thought for this migration we needed to create and directly return a new thread store state to redux using .processStoreOperations(). However, we actually should only just return the operations and just return state as is. The threadStore will be read by SQLiteDataHandler which populates redux with the migrated data from the ops.

Anyways, this util function is unused and can be removed

Depends on D12498

Test Plan

flow + at the end of the stack confirmed that migration 78 works as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, kamil.
ginsu requested review of this revision.Jun 19 2024, 6:48 PM
This revision is now accepted and ready to land.Jun 19 2024, 6:56 PM