Paths

Table of Contentst

[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker
Needs ReviewPublic
Actions

Authored by kamil on Thu, Jun 20, 3:33 PM.

Details

Reviewers

bartek
marcin
ashoat

Summary

ENG-8400 (see point 5. Logout).

This RPC will be used by Identity to inform Tunnelbroker about device logout.

Now remove the device token. Creating a follow-up task to delete persisted messages to device (ENG-8495).

Test Plan

Tested in next diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Thu, Jun 20, 3:33 PM

kamil held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptThu, Jun 20, 3:33 PM

kamil edited the summary of this revision. (Show Details)Thu, Jun 20, 3:35 PM

kamil added a parent revision: D12520: [Tunnelbroker] implement setting device token.

kamil added a child revision: D12526: [Identity] remove Tunnelbroker data on device removal.Thu, Jun 20, 3:36 PM

Harbormaster completed remote builds in B29847: Diff 41582.Thu, Jun 20, 3:50 PM

kamil published this revision for review.Thu, Jun 20, 4:10 PM

kamil mentioned this in D12538: [lib] introduce Tunnelbroker device token handler.Fri, Jun 21, 2:45 AM

What about undelivered_messages? Are they considered a "device data" too?

In D12525#355420, @bartek wrote:

What about undelivered_messages? Are they considered a "device data" too?

Yes, I created a follow-up task to implement this too: ENG-8495.

kamil edited the summary of this revision. (Show Details)Mon, Jun 24, 3:19 AM

bartek accepted this revision.Tue, Jun 25, 12:00 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

grpc/

mod.rs

18 lines

shared/

protos/

tunnelbroker.proto

8 lines

Diff 41582

View Options

services/tunnelbroker/src/grpc/mod.rs