Page MenuHomePhabricator
Differential D12536

[lib][web][native] set local Tunnelbroker device token on client
AcceptedPublic
Actions

Authored by kamil on Fri, Jun 21, 2:19 AM.
Tags
None
Referenced Files
F2124476: D12536.diff
Wed, Jun 26, 9:09 PM
F2122757: D12536.id41598.diff
Wed, Jun 26, 5:40 PM
Unknown Object (File)
Tue, Jun 25, 10:22 AM
Unknown Object (File)
Mon, Jun 24, 5:08 PM
Unknown Object (File)
Sun, Jun 23, 8:05 PM
Unknown Object (File)
Sun, Jun 23, 4:22 AM
Unknown Object (File)
Fri, Jun 21, 3:02 AM
Unknown Object (File)
Fri, Jun 21, 3:02 AM
View All 9 Files
Subscribers
ashoat
inka
tomek

Details

Reviewers
bartek
marcin
inka
Summary

ENG-8400 and ENG-8348.

Discussed this with @inka, and we think it makes the most sense. The alternative is adding a new redux action only to set localToken and dispatch it whenever dispatching setDeviceTokenActionTypes.

Depends on D12527

Test Plan
  1. On web make sure that on each refresh device token is set
  2. On native make sure that on app open device token is set, on logout remains the same

Diff Detail

Repository
rCOMM Comm
Branch
device-token
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
reducers/
10 lines
types/
4 lines
native/
push/
11 lines
web/
push-notif/
7 lines

Diff 41598

View Options

lib/reducers/tunnelbroker-device-token-reducer.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/push/push-handler.react.js

Loading...
View Options

web/push-notif/push-notifs-handler.js

Loading...